Fix #3292: annotations are now automatically refreshed#3325
Conversation
|
The changes are a bit hard to review, but I have tested it locally and the annotations are refreshed as desired. I have another point, though, one that might entail some work. Since you are already touching this code, do you see a change of refactoring the complete But to be honest, I do not get why file monitoring functionality should belong into the gui part. At least part of that should be extractable into a non-GUI part and should be movable into logic. If I look at |
|
Ok, I'll merge this now and will have a look at the collab package later. I second your concerns @lenhard, much of the code their should actually reside in logic. This would also help @Siedlerchr in his endeavor towards sharelatex integration. |
* upstream/master: Initializing EntryEditor Tabs on focus (#3331) Fix #3292: annotations are now automatically refreshed (#3325) Change integrity message for names depending on database mode (#3330) Fix location bundle with fast access (#3327) Small code cleanup Fix "path not found" exception Small fix in drag and drop handler of linked files (#3328) # Conflicts: # src/main/java/org/jabref/gui/DefaultInjector.java
* upstream/master: (31 commits) Source tab entry duplication (#3360) Use CITE_COMMENT not only for external latex editors but also for cop… (#3351) Updating with new translations (#3348) Upgrade error-prone (#3350) Jabref_pt_BR partially updated (#3349) Used late initialization for context menus (#3340) Fix NPE when calling with bib file as cmd argument (#3343) update mockito-core from 2.10.0 -> 2.11.0 (#3338) Remove underscore in Localized messages (#3336) Localisation: French: new entries translated (#3337) Refactoring: Lazy init of all editor tabs (#3333) Initializing EntryEditor Tabs on focus (#3331) Fix #3292: annotations are now automatically refreshed (#3325) Change integrity message for names depending on database mode (#3330) Fix location bundle with fast access (#3327) Small code cleanup Fix "path not found" exception Small fix in drag and drop handler of linked files (#3328) Fix NPE in MainTable (#3318) Increase relative size of abstract field in editor (#3320) ...
This PR aims to fix #3292 by removing the refresh button completely and monitoring the pdf files automatically for changes. In the progress of the implementation a few refactorings were made:
FileUpdateMonitorto a new class and convert the timestamp-based method to the new nio watcher interface.DatabaseChangeMonitor, where also some of the old code fromFileUpdateMonitornow finds a new home. This class is still a bit ugly but in my opinion better than before. I hope that the conflict handling still works as expected. I tested it but might have missed some special cases/configurations.gradle localizationUpdate?