Fix NPE in MainTable#3318
Merged
Merged
Conversation
LinusDietz
approved these changes
Oct 18, 2017
lenhard
approved these changes
Oct 19, 2017
lenhard
left a comment
Member
There was a problem hiding this comment.
Code-wise, this is fine. Let us ask the user to try and see if it fixes his problem.
halirutan
pushed a commit
to halirutan/jabref
that referenced
this pull request
Oct 20, 2017
* Fix NPE in MainTable * Fix build
lenhard
pushed a commit
that referenced
this pull request
Oct 20, 2017
* Made the LocalizationBundle a private class of Localization and ensured, that all accesses to it are only lookups in hashmaps Made all access of Location-messages a fast hash table lookup. Fixed one message in JabRefFrame that used an escaped key instead of the unescaped version. * Fix NPE in MainTable (#3318) * Fix NPE in MainTable * Fix build * Use of HashMap instead of Hashtable General code cleanup * Forgot to replace one null test * Reordering of import statements and fields Replacement of last null test with Objects.requireNonNull
Siedlerchr
added a commit
that referenced
this pull request
Oct 27, 2017
* upstream/master: (31 commits) Source tab entry duplication (#3360) Use CITE_COMMENT not only for external latex editors but also for cop… (#3351) Updating with new translations (#3348) Upgrade error-prone (#3350) Jabref_pt_BR partially updated (#3349) Used late initialization for context menus (#3340) Fix NPE when calling with bib file as cmd argument (#3343) update mockito-core from 2.10.0 -> 2.11.0 (#3338) Remove underscore in Localized messages (#3336) Localisation: French: new entries translated (#3337) Refactoring: Lazy init of all editor tabs (#3333) Initializing EntryEditor Tabs on focus (#3331) Fix #3292: annotations are now automatically refreshed (#3325) Change integrity message for names depending on database mode (#3330) Fix location bundle with fast access (#3327) Small code cleanup Fix "path not found" exception Small fix in drag and drop handler of linked files (#3328) Fix NPE in MainTable (#3318) Increase relative size of abstract field in editor (#3320) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As observed by @stefan-kolb in #3275 (comment) the NPE resulted from the strange
matches(null)code. This is fixed now. Not sure if this actually fixes the problem of #3275.gradle localizationUpdate?