Open statistics dialog from correct thread#3272
Merged
Merged
Conversation
Siedlerchr
reviewed
Oct 6, 2017
| @Override | ||
| public void run() { | ||
| DefaultTaskExecutor.runInJavaFXThread(JabRefFrame.this::showTrackingNotification); | ||
| SwingUtilities.invokeLater(new Runnable() { |
Member
There was a problem hiding this comment.
It would be nice if you could convert this to a lambda expression. (Unfortunately this lamdba styles is not possible with the timer task)
Just:
SwingUtilities.invokeLater(() -> {
DefaultTaskExecutor.runInJavaFXThread(JabRefFrame.this::showTrackingNotification);
});
Contributor
Author
There was a problem hiding this comment.
Yes, this definitely looks cleaner. Applied and re-tested.
The dialog to ask for collecting anonymous statistics needs to be created in the Swing EDT. Do so using SwingUtilities.invokeLater(). This is a follow-up on 7ef2b3a and should finally fix JabRef#2955.
429b053 to
fd16110
Compare
Siedlerchr
approved these changes
Oct 6, 2017
tobiasdiez
approved these changes
Oct 7, 2017
tobiasdiez
left a comment
Member
There was a problem hiding this comment.
What the heck is this: first you run it in a new thread, then move it to the swing thread and finally invoke it actually in the JavaFX thread. Ok...if it works.
Siedlerchr
added a commit
that referenced
this pull request
Oct 7, 2017
* upstream/master: (113 commits) Open statistics dialog from correct thread (#3272) Fix for issue 2811: bibtexkey generator does not use crossref information (#3248) Fix for issue 3143: Import entry from clipboard in different formats (#3243) French translation correction (#3262) Wait to ask to collect anonymous statistics in JabRefExecutorService to allow jvm to terminate (#3266) Directory pattern bracketed expressions (#3238) Show development information Release v4.0 add another author to mailmap moved changelog entry to the right category update new AUTHORS info Update log4j from 2.9.0 -> 2.9.1 fix dblp fetcher Add missing Turkish translation Add "-console" parameter for Windows launcher (#3242) Path check converted to if statement Changelog updated Fixed renaming files which are not in main directory. Only use last name for auto completion in search bar. Fixes JabRef#253 Implemented issue #3229 (#3233) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dialog to ask for collecting anonymous statistics needs to be created in
the Swing EDT. Do so using SwingUtilities.invokeLater().
This is a follow-up on 7ef2b3a and should finally fix #2955.
No addition to CHANGELOG.md as 7ef2b3a already included a corresponding entry.
gradle localizationUpdate?