Fix for issue 2811: bibtexkey generator does not use crossref information#3248
Conversation
Siedlerchr
left a comment
There was a problem hiding this comment.
Thanks for your contribution! Very good!
Just remove the line with the sys out and it looks very good
| database.insertEntry(entry1); | ||
| String bibtexString = "@ARTICLE{entry2, author={Mari D. Herland and Mona-Iren Hauge and Ingeborg M. Helgeland}}"; | ||
| BibEntry entry2 = BibtexParser.singleFromString(bibtexString, importFormatPreferences).get(); | ||
| database.insertEntry(entry2); |
There was a problem hiding this comment.
Seems like you have forgotten to remove the system out print here
tobiasdiez
left a comment
There was a problem hiding this comment.
Thank you again for a great contribution! I only have a small remark concerning the tests and then this can be merged.
| BibDatabase database = new BibDatabase(); | ||
| BibEntry entry1 = new BibEntry(); | ||
| entry1.setField(FieldName.CROSSREF, "entry2"); | ||
| database.insertEntry(entry1); |
There was a problem hiding this comment.
Please construct the entry by hand (as you did for entry1) instead of using the parser. I know, the other tests also work like that but this is bad design.
|
@125m125 That is really an impressive amount of tests, good job! There are two merge conflicts. Could you resolve those? Once that's done this PR is ready to go into master. |
|
And once again thanks! |
* upstream/master: (113 commits) Open statistics dialog from correct thread (#3272) Fix for issue 2811: bibtexkey generator does not use crossref information (#3248) Fix for issue 3143: Import entry from clipboard in different formats (#3243) French translation correction (#3262) Wait to ask to collect anonymous statistics in JabRefExecutorService to allow jvm to terminate (#3266) Directory pattern bracketed expressions (#3238) Show development information Release v4.0 add another author to mailmap moved changelog entry to the right category update new AUTHORS info Update log4j from 2.9.0 -> 2.9.1 fix dblp fetcher Add missing Turkish translation Add "-console" parameter for Windows launcher (#3242) Path check converted to if statement Changelog updated Fixed renaming files which are not in main directory. Only use last name for auto completion in search bar. Fixes JabRef#253 Implemented issue #3229 (#3233) ...
see #2811
The BibTex key generator now uses crossreferenced entries if required fields are empty.