Additional filter functionality for Check Integrity popup#3120
Merged
lenhard merged 2 commits intoAug 18, 2017
Conversation
New 'Filter All' and 'Filter None' buttons can be clicked by the user to check/uncheck all options in the filter menu. Updated localization info with text for aforementioned buttons.
Siedlerchr
reviewed
Aug 18, 2017
Siedlerchr
left a comment
Member
There was a problem hiding this comment.
Thank you very much for your contribution, code lgtm, I will test the function later
lenhard
approved these changes
Aug 18, 2017
lenhard
left a comment
Member
There was a problem hiding this comment.
Thanks for your PR. The simplest solution is usually best.
I have tested the PR locally and it works. The code looks fine as well.
@JabRef/developers We wanted to do a feature freeze for 4.0. So should we wait with merging this? I would say we can merge it anyway. After all, it's not too big. The only "problem" is that the translators would need to do another round.
Member
|
We still have many open translations (
http://help.jabref.org/en/TranslatingGUI), so that is not a con. The
feature has a very low risk break anything. I would just include it.
Am 18.08.2017 11:32 schrieb "Jörg Lenhard" <notifications@github.com>:
… ***@***.**** approved this pull request.
Thanks for your PR. The simplest solution is usually best.
I have tested the PR locally and it works. The code looks fine as well.
@JabRef/developers <https://github.com/orgs/JabRef/teams/developers> We
wanted to do a feature freeze for 4.0. So should we wait with merging this?
I would say we can merge it anyway. After all, it's not too big. The only
"problem" is that the translators would need to do another round.
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
<#3120 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABTafkXTsgkgb7BtM91DhU9RfdwsMW2Jks5sZVoagaJpZM4O6-V_>
.
|
Member
|
Ok, perfect! @Andrew-Lev Thank you very much for your contribution! You're very welcome to provide more :-) |
Contributor
|
@koppor Does the timeframe for the release of 4.0 allow a call to translators? |
Member
|
Absolutely!!
Am 18.08.2017 14:47 schrieb "MLEP" <notifications@github.com>:
… @koppor <https://github.com/koppor> Does the timeframe for the release of
4.0 allow a call to translators?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3120 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABTafmLTjIiCVx3punVN2Me-vdWh35SOks5sZYfigaJpZM4O6-V_>
.
|
Siedlerchr
added a commit
that referenced
this pull request
Aug 18, 2017
* upstream/master: Move event processing from source tab into entry editor (#3116) Update Menu_ja.properties (#3125) Update JabRef_ja.properties (#3126) Localization: French: Translation of new entries (#3124) Fix changelog - no date for fixes Fix markdown Additional filter functionality for Check Integrity popup (#3120) Workround: make snapcraft find jabref.desktop Enable publishing so that users do not need to execute --devmode Update jabref.desktop Enable publishing so that users do not need to execute --devmode Release beta version also on snapcraft Workround: make snapcraft find jabref.desktop Fix branch name Use newer image Set executable for all (and not for owner only) Add comment on version replacement Enable creation of an Ubuntu snap
Siedlerchr
added a commit
that referenced
this pull request
Aug 22, 2017
* upstream/master: (269 commits) Customjfxpanel (#3128) Make constants more obvious; improve logging Rename variables and make use of Java8 streams Re-add "Normalize to BibTex name format" context menu item and menu item tooltips Tweak build.gradle and external-libraries Work in feedback Files can be dropped to entry preview panel to attach a file again. Update IntelliJ howto to IntelliJ version 2017.2 Move event processing from source tab into entry editor (#3116) Update Menu_ja.properties (#3125) Update JabRef_ja.properties (#3126) Localization: French: Translation of new entries (#3124) Fix changelog - no date for fixes Fix markdown Additional filter functionality for Check Integrity popup (#3120) Workround: make snapcraft find jabref.desktop Enable publishing so that users do not need to execute --devmode Update jabref.desktop Enable publishing so that users do not need to execute --devmode Release beta version also on snapcraft ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2718
I added new 'Filter All' and 'Filter None' buttons. They can be clicked by the user to
check/uncheck all options in the filter menu. When one of the buttons gets clicked the system will iterate through the existing menu components and toggle the checkmarks and info displayed.
I wasnt sure on the best placement of the buttons in the window so went with the simplest solution
Updated localization info with text for aforementioned buttons.