Move event processing from source tab into entry editor#3116
Merged
Conversation
Siedlerchr
approved these changes
Aug 16, 2017
Member
|
AS this is a small but important change I merge this i in now. |
Siedlerchr
added a commit
that referenced
this pull request
Aug 18, 2017
* upstream/master: Move event processing from source tab into entry editor (#3116) Update Menu_ja.properties (#3125) Update JabRef_ja.properties (#3126) Localization: French: Translation of new entries (#3124) Fix changelog - no date for fixes Fix markdown Additional filter functionality for Check Integrity popup (#3120) Workround: make snapcraft find jabref.desktop Enable publishing so that users do not need to execute --devmode Update jabref.desktop Enable publishing so that users do not need to execute --devmode Release beta version also on snapcraft Workround: make snapcraft find jabref.desktop Fix branch name Use newer image Set executable for all (and not for owner only) Add comment on version replacement Enable creation of an Ubuntu snap
Siedlerchr
added a commit
that referenced
this pull request
Aug 22, 2017
* upstream/master: (269 commits) Customjfxpanel (#3128) Make constants more obvious; improve logging Rename variables and make use of Java8 streams Re-add "Normalize to BibTex name format" context menu item and menu item tooltips Tweak build.gradle and external-libraries Work in feedback Files can be dropped to entry preview panel to attach a file again. Update IntelliJ howto to IntelliJ version 2017.2 Move event processing from source tab into entry editor (#3116) Update Menu_ja.properties (#3125) Update JabRef_ja.properties (#3126) Localization: French: Translation of new entries (#3124) Fix changelog - no date for fixes Fix markdown Additional filter functionality for Check Integrity popup (#3120) Workround: make snapcraft find jabref.desktop Enable publishing so that users do not need to execute --devmode Update jabref.desktop Enable publishing so that users do not need to execute --devmode Release beta version also on snapcraft ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves the most critical part of #3113
The source tab did not properly unregister itself from the event bus. For some reason, I did not manage to get this working when the source tab takes care of deregistration. Therefore, I moved all event handling out of the source tab and into the entry editor.
Using jvisualvm, I can see that garbage collection works with this PR. Cycling through the main table with the entry editor open increases used RAM. When you force garbage collection, the used heap goes down to close to zero again, instead of staying at a higher plateau. See attached screenshot
So this fixes the memory leak. The overall heap size doesn't go down, but that's a different issue.
gradle localizationUpdate?