[WIP] Create PDF file Exporter#2706
Conversation
Remove code that produces NPE
* upstream/master: fix ID consideration in DuplicateCheck Add ArXiv identifier batch lookup (#2710) Update mockito from 2.7.19 to 2.7.21 More defensive identifier list #2708 Revert "Add more identifier field names #2708" Add more identifier field names #2708 Consider entries as equal if their DOI matches #2708 Imports Imports Move duplicate detection to logic Reuse edit distance class Refactoring EntryTypeDialog Fetching Autogenerates BibTeX Key (#2709) Add changelog entry Increase permitted size of StringUtil Make sure that JavaFx shuts down in case another JabRef instance is already open
Don't replace existings
| * should be exported. The list of entries must be non null | ||
| * @throws Exception | ||
| */ | ||
| void performExport(BibDatabaseContext databaseContext, Path file, Charset encoding, List<BibEntry> entries) |
There was a problem hiding this comment.
I actually prefer these export methods that take the file as a Path instead of string.
There was a problem hiding this comment.
Yeah, I wanted to use it, too. However, the method with that signature never gets called which led to an NPE.
In ExportAction only the one with String is called.
There was a problem hiding this comment.
Maybe change ExpoortAction then? For now the Path method can be implemented as default and invoking the stringy one.
tobiasdiez
left a comment
There was a problem hiding this comment.
I'm missing a test for the new exporter but otherwise it looks good.
Please also add a changelog entry.
| public class LinkedFileExporter extends ExportFormat { | ||
|
|
||
| public LinkedFileExporter() { | ||
| super("Files Exporter", "Files", null, null, ".*"); |
There was a problem hiding this comment.
Maybe "Export linked files" as name? not sure.
|
Should we also move the "Send es email" functionality to the export menu? |
|
Hm, I would distinguish between Export and Share. Send as Email sounds to be me like sharing it whereas Export is a lowerlevel primitive which is not always for sharing the data. |
|
I like the suggestion by @simonharrer. "Share" fits better than "Export". |
|
DevCall Decision: Move to Tools -> Copy Files |
* upstream/master: (39 commits) Fix fetcher test Allow failures for fetcher test (#2730) Use JabRefExecutor service Move DOI fetching to separate thread #2682 Remove gui dependency in logic (#2726) Fixed freeze on Mac OS X when creating/editing groups (#2727) Only ask once if telemetry data should be collected Update wiremock from 2.5.1 to 2.6.0 Update mockito-core from 2.7.21 to 2.7.22 Update log4j to latest version Azure test (#2724) Fix build Move expand filename to FileUtil Unicode conversion bibtexkey (#2720) Add sorting of all groups and subgroups, recursively (#2666) Only check capitalization of note and howpublished fields if they start with a word character Remove overhauled @author tag Implement #1359: collect telemetry (#2283) Add licenses of new dependencies Fix cssStyleHelper warnings ...
TODO: Add to menu
* upstream/master: Speedup start by improving Application Insights configuration (#2737) Localization: French: Menu: Translation of new entries (#2735) Localization: French: General: Translation of new entries (#2736) Update Chinese translation. (#2734) Fix 2701 too may files found (#2732) Update errorprone from 0.0.8 to 0.0.10, because of update of Gradle to 3.5 Update gradle from 3.4.1 to 3.5
|
@JabRef/developers I need some help here. I want to execute the thing in a background thread and make it cancable. Looked already at some other, but it's not clear to me, why some of them are implemented in Frame and some in BasePanel. And I never worked with this AbstractWorker stuff. Any help welcome |
|
Like this ? |
* upstream/master: (84 commits) Update README.md Update CHANGELOG.md Fixes #2789 Add Referer to API call (#2794) Change some FileDialogs to DialogService (#2767) Fix for issue 2762: Change CSV export to separate all names using semicolon (#2793) Set eclipse line wrapping to maximum Do not log an exception if side pane was not found (#2791) Added 'Ink' to the supported FileAnnotationType (required to close #2777) Renamed parseFileAnnotationType() to parse() Reimplement date editor in JavaFX (#2781) Update CONTRIBUTING.md Add new author Fixes handling of unknown PDAnnotation types. Update Checkstyle Version fix some more checkstyle warnings fix some more checkstyle warnings Fix Build failure, hopefully Spanish translation (#2773) Fixes #2766 If file is not found annotations might be null Fix language tests ... # Conflicts: # src/main/java/org/jabref/logic/util/io/FileUtil.java
|
@Siedlerchr how would you describe the status of this PR? Is it feasible to include it into 4.0 or should we postpone it to 4.1? |
|
I would postpone it to 4.1, as we want the 4.0 to be stable
Am 08.08.2017 10:26 vorm. schrieb "Linus Dietz" <notifications@github.com>:
… @Siedlerchr <https://github.com/siedlerchr> how would you describe the
status of this PR? Is it feasible to include it into 4.0 or should we
postpone it to 4.1?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2706 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AATi5JbmRyZ1o8w4O-vU2Z2Tz3UT0022ks5sWBvKgaJpZM4Mw1bj>
.
|
|
This branch is followed up at #3147, because it was renamed to |
Create an exporter that enables the export of Files.
Only caveat: You have to enter an arbitrary filename in the save dialog. The exporter then uses the directory.
Implements #2539
gradle localizationUpdate?