Fixes #2789 Add Referer to API call#2794
Merged
Merged
Conversation
Member
|
Could you please add a test? The IEEE-Tests we already have do not cover this fulltext finder |
Member
Author
|
@Siedlerchr Unfortunately it has a lot of GUI and Preferences interdependencies. As it seems we do not have tests for any of those query fetchers yet?! |
Member
|
Of course we have some test for those fetchers - but only for those which have been rewritten to the new structure, e.g., https://github.com/JabRef/jabref/blob/master/src/test/java/org/jabref/logic/importer/fetcher/DBLPFetcherTest.java which tests https://github.com/JabRef/jabref/blob/master/src/main/java/org/jabref/logic/importer/fetcher/DBLPFetcher.java |
Member
Author
|
Yes, I was talking about the old ones! |
Member
|
Is there an Issue for rewriting those; tagged with "beginner"? 😇
Am 26.04.2017 12:14 schrieb "Stefan Kolb" <notifications@github.com>:
Yes, I was talking about the old ones!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2794 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABTaftFGcQGu7JpKoGIuuXBs8NjIzm7sks5rzxkYgaJpZM4NHfef>
.
|
Member
Author
|
Tried to add a test, but got stuck with so many dependencies and calls on different Preferences classes :( |
Siedlerchr
added a commit
that referenced
this pull request
Apr 29, 2017
* upstream/master: (84 commits) Update README.md Update CHANGELOG.md Fixes #2789 Add Referer to API call (#2794) Change some FileDialogs to DialogService (#2767) Fix for issue 2762: Change CSV export to separate all names using semicolon (#2793) Set eclipse line wrapping to maximum Do not log an exception if side pane was not found (#2791) Added 'Ink' to the supported FileAnnotationType (required to close #2777) Renamed parseFileAnnotationType() to parse() Reimplement date editor in JavaFX (#2781) Update CONTRIBUTING.md Add new author Fixes handling of unknown PDAnnotation types. Update Checkstyle Version fix some more checkstyle warnings fix some more checkstyle warnings Fix Build failure, hopefully Spanish translation (#2773) Fixes #2766 If file is not found annotations might be null Fix language tests ... # Conflicts: # src/main/java/org/jabref/logic/util/io/FileUtil.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #2789.
Please check if this works for you.