EntryTypeDialog Fetching Autogenerates BibTeX Key#2709
Merged
Conversation
tobiasdiez
approved these changes
Apr 4, 2017
tobiasdiez
left a comment
Member
There was a problem hiding this comment.
At some point we should think about a layer between the GUI and fetcher, which handles these kinds of post-processing. For the moment the change is good enough in my opinion.
Siedlerchr
added a commit
that referenced
this pull request
Apr 5, 2017
* upstream/master: fix ID consideration in DuplicateCheck Add ArXiv identifier batch lookup (#2710) Update mockito from 2.7.19 to 2.7.21 More defensive identifier list #2708 Revert "Add more identifier field names #2708" Add more identifier field names #2708 Consider entries as equal if their DOI matches #2708 Imports Imports Move duplicate detection to logic Reuse edit distance class Refactoring EntryTypeDialog Fetching Autogenerates BibTeX Key (#2709) Add changelog entry Increase permitted size of StringUtil Make sure that JavaFx shuts down in case another JabRef instance is already open
Siedlerchr
added a commit
that referenced
this pull request
Apr 6, 2017
* upstream/master: (35 commits) Update antlr from 4.6 to 4.7 Fix build fix ID consideration in DuplicateCheck Add ArXiv identifier batch lookup (#2710) Update mockito from 2.7.19 to 2.7.21 More defensive identifier list #2708 Revert "Add more identifier field names #2708" Add more identifier field names #2708 Consider entries as equal if their DOI matches #2708 Imports Imports Move duplicate detection to logic Reuse edit distance class Refactoring EntryTypeDialog Fetching Autogenerates BibTeX Key (#2709) Add changelog entry Increase permitted size of StringUtil Make sure that JavaFx shuts down in case another JabRef instance is already open Remove obsolete localization strings Hide context menu before group edit/add (probably a JavaFX vs Swing problem) ... # Conflicts: # src/main/java/org/jabref/gui/groups/GroupTreeController.java # src/main/java/org/jabref/gui/groups/GroupTreeViewModel.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is aimed to resolve #2687.
I struggled a bit to decide where to add the generation of keys, as they depend on the database. Finally, I have added it directly in the EntryTypeDialog, as I felt that BasePanel.insertEntry() (line 1180) would have too many side-effects for manual inserting.
An alternative would be to write two insertEntry() methods in the BasePanel, one for normal inserts, and one with regeneration of keys.
Also I have deleted the IdBasedEntryFetcher.java, as it was not used anymore anywhere.
- [ ] Tests created for changes- [ ] Screenshots added (for bigger UI changes)- [ ] If you changed the localization: Did you rungradle localizationUpdate?