Improve perfomance of opening a database that still used the old groups format#2636
Merged
Conversation
stefan-kolb
approved these changes
Mar 13, 2017
Siedlerchr
added a commit
that referenced
this pull request
Mar 14, 2017
* upstream/master: Donate to JabRef! Issuestats.com is down Add link to logo creator Improve perfomance of opening a database that still used the old groups format (#2636) Set POSIX filepermissions to 644 (#2637) Fix #2629: Removing entry from group updates view properly Remove empty tooltip in group panel Refactored around the PDF Annotation Importer (#2624) Fix last import issue Fix imports and some reformatting Fix wrong import order Add missing svg icon RIP old icon Add new logo files (#2164) # Conflicts: # src/main/java/org/jabref/gui/groups/GroupSelector.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the conversion of the old groups format to the new one was performed after the database was completely loaded and displayed. Thus after every change during the conversion the groups panel and main table were redrawn, resulting in performance problems (in particular with larger db's).
Now the conversion is done before the db is displayed (and thus nobody yet listens to the changes).
Fixes: http://discourse.jabref.org/t/v3-8-2-x64-windows-problem-saving-large-bib-libraries/456
gradle localizationUpdate?