Skip to content

Add new logo files#2164

Merged
koppor merged 8 commits into
masterfrom
newLogo
Mar 9, 2017
Merged

Add new logo files#2164
koppor merged 8 commits into
masterfrom
newLogo

Conversation

@matthiasgeiger

@matthiasgeiger matthiasgeiger commented Oct 14, 2016

Copy link
Copy Markdown
Member

Still [WIP]:

  • Add PNG versions in Java (different abstractions for different sizes)
  • Create new *.ico and *.icns files
  • Check installer
  • Issue: Invisible Icon in Win 10 due to same background color (see also comment from Tobias)
  • create file icon for associated *.bib files
    • create ico files for Win and Mac
    • configure install4j

Normal todos:

  • Change in CHANGELOG.md described
  • [ ] Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • [ ] Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • [ ] If you changed the localization: Did you run gradle localizationUpdate?

@tobiasdiez

Copy link
Copy Markdown
Member

Most of the apps on the Windows Start Screen (Win 10) have a white foreground and a colorful background. Can we also create an inverted image of the new logo to adhere to this style? (Or after skimming through the guidelines I think a white Icon with transparent background is needed)

@stefan-kolb stefan-kolb removed this from the v3.7 milestone Oct 27, 2016
@lenhard lenhard added the jabcon label Feb 10, 2017
@lenhard

lenhard commented Mar 6, 2017

Copy link
Copy Markdown
Member

What is the status here? It would be cool to have the new icon soon :-)

@matthiasgeiger

Copy link
Copy Markdown
Member Author

Basically it's ready to merge - further improvement would be to create a file-icon but this is just a nice-to-have feature.

As I don't have that much time in the next weeks I'll merge the current status (after rebasing and fixing the resulting errors due to the package changes 😉)

@matthiasgeiger matthiasgeiger added this to the v4.0 milestone Mar 6, 2017
@matthiasgeiger matthiasgeiger changed the title [WIP] Add new logo files Add new logo files Mar 6, 2017
@matthiasgeiger matthiasgeiger added status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers and removed jabcon labels Mar 6, 2017
@matthiasgeiger

matthiasgeiger commented Mar 6, 2017

Copy link
Copy Markdown
Member Author

Okay... should be ready-for-review from my side..

@chochreiner would be cool if you could check whether the installation on a Mac is possible successfully and showing the new logo. Thanks!

Builds are available at http://builds.jabref.org/newLogo/

@chochreiner

Copy link
Copy Markdown
Contributor

works fine 👍

Comment thread CHANGELOG.md Outdated
## [Unreleased]

### Changed
- JabRef has a new logo!

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add the name and link to the designer?

@koppor koppor merged commit 8e36cef into master Mar 9, 2017
@koppor koppor deleted the newLogo branch March 9, 2017 16:33
Siedlerchr added a commit that referenced this pull request Mar 14, 2017
* upstream/master:
  Donate to JabRef!
  Issuestats.com is down
  Add link to logo creator
  Improve perfomance of opening a database that still used the old groups format (#2636)
  Set POSIX filepermissions to 644 (#2637)
  Fix #2629: Removing entry from group updates view properly
  Remove empty tooltip in group panel
  Refactored around the PDF Annotation Importer (#2624)
  Fix last import issue
  Fix imports and some reformatting
  Fix wrong import order
  Add missing svg icon
  RIP old icon
  Add new logo files (#2164)

# Conflicts:
#	src/main/java/org/jabref/gui/groups/GroupSelector.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants