Follow up #2428#2438
Merged
Merged
Conversation
lenhard
approved these changes
Jan 1, 2017
lenhard
left a comment
Member
There was a problem hiding this comment.
Just a few minor things, otherwise the code looks good. Can you also rename the class Arxiv to ArxivFetcher (since this is the appropriate name, I guess)?
| private Set<? extends Class<?>> getClasses(List<?> objects) { | ||
| return objects.stream().map(Object::getClass).collect(Collectors.toSet()); | ||
| } | ||
| } No newline at end of file |
Member
There was a problem hiding this comment.
Missing newline at the end of the file
|
|
||
| assertEquals(Optional.of(new ArXivIdentifier("0710.0994")), parsed); | ||
| } | ||
| } No newline at end of file |
Member
There was a problem hiding this comment.
Missing newline at the end of the file.
Member
Author
|
Fixed newline issues but didn't renamed the fetcher since most of the fetchers don't have a "Fetcher" suffix. |
Siedlerchr
added a commit
that referenced
this pull request
Jan 18, 2017
* upstream/master: Save deletion of current searchquery (#2469) Update dev dependencies (mockito, wiremock, assertj) Update BouncyCastle (1.55->1.56), ANTRL4 (4.5.3->4.6), jsoup (1.10.1->1.10.2) Group all checker which only check the value of one field (#2437) Follow up #2428 (#2438) Fix conversion of "'n" and "\'{n}" from LaTeX to Unicode (#2464) Fix failing tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from #2428:
gradle localizationUpdate?