Fix #2427: Arxiv fetcher works with prefix#2428
Merged
Merged
Conversation
stefan-kolb
suggested changes
Dec 22, 2016
|
|
||
| private Optional<ArXivEntry> searchForEntryById(String identifier) throws FetcherException { | ||
| identifier = identifier.replace("arxiv:", ""); | ||
| identifier = identifier.replace("arXiv:", ""); |
Member
There was a problem hiding this comment.
Can you just replace this via a regex? /arxiv:?/i
Contributor
There was a problem hiding this comment.
I would vote for an ArXivID class, similar to the DOI one which can handle such a case.
| assertEquals(Optional.of(new URL("http://arxiv.org/pdf/1603.06570v1")), finder.findFullText(entry)); | ||
| } | ||
|
|
||
| @Test |
Member
There was a problem hiding this comment.
I would omit the comment here. It is a test for expected behavior. Doesnt matter which bug/problem it fixed.
| assertEquals(Optional.of(sliceTheoremPaper), finder.performSearchById("1405.2249")); | ||
| } | ||
|
|
||
| @Test |
Siedlerchr
reviewed
Dec 23, 2016
| @Test | ||
| // Test for https://github.com/JabRef/jabref/issues/2427 | ||
| public void findByEprintWithPrefix() throws IOException { | ||
| entry.setField("eprint", "arXiv:1603.06570"); |
Siedlerchr
reviewed
Dec 23, 2016
| assertEquals(Optional.of(sliceTheoremPaper), finder.performSearchById("1405.2249")); | ||
| } | ||
|
|
||
| @Test |
Member
|
I merged it and will do the requested changes now to get this into 3.8.2. |
tobiasdiez
added a commit
that referenced
this pull request
Jan 15, 2017
Siedlerchr
added a commit
that referenced
this pull request
Jan 18, 2017
* upstream/master: Save deletion of current searchquery (#2469) Update dev dependencies (mockito, wiremock, assertj) Update BouncyCastle (1.55->1.56), ANTRL4 (4.5.3->4.6), jsoup (1.10.1->1.10.2) Group all checker which only check the value of one field (#2437) Follow up #2428 (#2438) Fix conversion of "'n" and "\'{n}" from LaTeX to Unicode (#2464) Fix failing tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gradle localizationUpdate?