New Iconset by stefan-kolb · Pull Request #230 · JabRef/jabref

stefan-kolb · 2015-10-12T22:55:40Z

Also see #130

Unlike expected, PNG files do not look sharper than the font version for me
Anyhow, we should go up to 24px as 16px seems way to small
~~Strangely, some icons are missing in the materialize Github repository, e.g. settings~~ not relevant
We still have duplicated and unused icons in the properties file
Open file icon should be either file-pdf or file-document (or attachment) depending on actual file type.
How are icons for external file types handled? users cannot set this anymore, they have to use the default icons instead.
squash commits so that temporary binary files are not in the history
separator are not removed when the icons are hidden (see special fields like rank)
add information about used font into external-libraries.txt and update "About" content

koppor · 2015-10-12T23:42:22Z

When checking for the size of the icons, please also check high resolutions settings:

matthiasgeiger · 2015-10-13T07:10:48Z

So we should use the Font as this enables simple resizing.
I will investigate whether it is possible to make the icons sharper somehow...

kubovy · 2015-10-14T16:14:24Z

What about some icon dpi scheme ala android: mdpi, hdpi, xhdpi, ...? Since resolution are growing. If you want to use vector format what about SVG?

simonharrer · 2015-10-14T16:44:07Z

We wanted to use an icon font. This should scale for all resolutions..

simonharrer · 2015-10-19T15:01:56Z

What needs to be investigated

the menu item gets bigger when we use the 24px icon. This looks strange when we have normal menu items with no icons and menu items with the 24px icons in a single menu.
disabled icons look strange

ideas

the selection of the color to mark an entry should be done in the tool bar as well right next the marker symbol - or we change the color symbol in the toolbar depending on the current color selection.

simonharrer · 2015-10-20T08:14:06Z

👍 for linking to the donations page as it also explains how the money is spent.

matthiasgeiger · 2015-10-22T12:19:44Z

Okay... I think we are coming down the stretch...

@koppor @lenhard (and all interested others): Do you have some feedback to be integrated before we merge into master?

…lipboard, send via email, copy bibtex key, copy cite bibtex key and copy bibtex key and title.

simonharrer · 2015-10-24T21:17:10Z

Squashed the commits so that temporary png files and fonts are pruned from the history. And removed the ability to change the icon of an external file type entry. Hence, only a single item in this PR is remaining.

koppor · 2015-10-25T01:47:02Z

The last issue was partially addressed by e57fb49. If #257 goes through, this PR can be merged as is.

New Iconset

4a551a87c3 copied .github/workflows/sheldon.yaml from styles 210d56d1a3 copied .github/workflows/sheldon.yaml from styles 684ab7c021 copied .github/workflows/sheldon.yaml from styles 3313747417 Update Sheldon to csl-styles 2.0 d568b6b3df copied .github/workflows/sheldon.yaml from styles 96d7471411 copied .github/workflows/sheldon.yaml from styles 65417b390f copied .github/workflows/sheldon.yaml from styles 841eaef79f copied .github/workflows/sheldon.yaml from styles 5369c686fd copied .github/workflows/sheldon.yaml from styles ab41f49d31 copied .github/workflows/sheldon.yaml from styles dfbd6e4f0f copied .github/workflows/sheldon.yaml from styles 0c025165bd copied .github/workflows/sheldon.yaml from styles 511a577c5a copied .github/workflows/sheldon.yaml from styles b963638d37 copied .github/workflows/sheldon.yaml from styles 45813b71b1 add new terms for 1.0.2 (#230) 4b179c7ce8 copied .github/workflows/merge.yaml from styles 86b9844aba update to csl 2.0 18458dcf86 bundle update git-subtree-dir: buildres/csl/csl-locales git-subtree-split: 4a551a87c30db341809dd203765cd8f29c070b36

stefan-kolb added the component: ui label Oct 12, 2015

stefan-kolb added this to the v2.80 milestone Oct 12, 2015

koppor mentioned this pull request Oct 12, 2015

New UI #113

Closed

stefan-kolb force-pushed the icons branch from 0d796b4 to eb28246 Compare October 20, 2015 08:23

simonharrer force-pushed the icons branch from 6d206cb to 5479ac0 Compare October 22, 2015 08:57

simonharrer force-pushed the icons branch from 8eb0f26 to 6860fe4 Compare October 24, 2015 21:03

matthiasgeiger and others added 17 commits October 24, 2015 23:11

Towards using icon fonts

77b69ba

switch to FontIcons

be306eb

Add missing Icons and restore old implementation of getImage

935d4a0

use more FontIcons

f80d0fd

Changes to use font based icons

d79121c

Further changes to use font based icons

59e1f13

Further changes to use font based icons

34c0987

Some more changes to FontIcons

a810123

Some more changes to FontIcons

af454dd

Change some more icons to FontBasedIcon

254bb47

Change ranking icons to stars

e9d495b

Fix some more icons

006b678

Fix icons for OpenOffice connector

c9a2864

Fix icons for Plain text import

345bc72

Resolves #238 Add a donation link to help menu and toolbar

e2f8ecf

Rename DragNDropArrow to MoveTabArrow and replace by Font

7c18a83

replace some of the last image icons

1791a9f

matthiasgeiger and others added 17 commits October 24, 2015 23:13

fix representing icon for Rank specialfield

8ec6f56

create disabled icons for RightClickMenu and JabRefFrame menus

47be743

remove some add preamble icon and toogle group highlighting buttons

b0dcc85

minor icon tweaks

7ed63ca

Add separators to make grouping more clear

de34bd4

Remove code redundancy.

faa6ba8

Icon for external application changes in menu when changed in taskbar.

3b79e5e

minor change of default colors

e0ca9c6

create open file icon depending on used file type

3f3a4b8

Another separator to group the database actions

cb720cc

add search toggles to view menu and icon bar

52ee633

remove unused method

12bbafc

Right-click menu and edit menu show the same five actions export to c…

1e9d591

…lipboard, send via email, copy bibtex key, copy cite bibtex key and copy bibtex key and title.

move seperators to avoid double seperators

1a06f30

remove icon for findUnlinkedFiles

06cc6f5

Groups are shown as a high-level menu entry.

db1ff91

Use HELP symbol instead of text for help buttons.

0549a08

simonharrer force-pushed the icons branch from 6860fe4 to 0549a08 Compare October 24, 2015 21:13

Add Material Design Icons to external-libraries.txt

e57fb49

koppor added 2 commits October 25, 2015 19:37

Merge branch 'master' into icons

0088cc9

Add information on Material Design Icons to About.html files

f30f17f

koppor added a commit that referenced this pull request Oct 25, 2015

Merge pull request #230 from JabRef/icons

a5bb73c

New Iconset

koppor merged commit a5bb73c into master Oct 25, 2015

koppor deleted the icons branch October 26, 2015 00:06

koppor mentioned this pull request Jan 1, 2016

2.11 icons: How to retrieve these into 3.1 #613

Closed

This was referenced Sep 5, 2016

Icon update to v1.5.54 + usage of regEx and case sensitivity icon #961

Merged

[WIP] Refactor ExternalFileType #1924

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

New Iconset#230

New Iconset#230
koppor merged 49 commits into
masterfrom
icons

stefan-kolb commented Oct 12, 2015

Uh oh!

koppor commented Oct 12, 2015

Uh oh!

matthiasgeiger commented Oct 13, 2015

Uh oh!

kubovy commented Oct 14, 2015

Uh oh!

simonharrer commented Oct 14, 2015

Uh oh!

simonharrer commented Oct 19, 2015

Uh oh!

simonharrer commented Oct 20, 2015

Uh oh!

matthiasgeiger commented Oct 22, 2015

Uh oh!

simonharrer commented Oct 24, 2015

Uh oh!

koppor commented Oct 25, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

stefan-kolb commented Oct 12, 2015

Uh oh!

koppor commented Oct 12, 2015

Uh oh!

matthiasgeiger commented Oct 13, 2015

Uh oh!

kubovy commented Oct 14, 2015

Uh oh!

simonharrer commented Oct 14, 2015

Uh oh!

simonharrer commented Oct 19, 2015

ideas

Uh oh!

simonharrer commented Oct 20, 2015

Uh oh!

matthiasgeiger commented Oct 22, 2015

Uh oh!

simonharrer commented Oct 24, 2015

Uh oh!

koppor commented Oct 25, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants