Skip to content

Improve About.html files#257

Merged
koppor merged 5 commits into
masterfrom
about_file_improvements
Oct 26, 2015
Merged

Improve About.html files#257
koppor merged 5 commits into
masterfrom
about_file_improvements

Conversation

@koppor

@koppor koppor commented Oct 25, 2015

Copy link
Copy Markdown
Member
  • remove local license files in the help
    • replace License.html by online link
  • replace copyright statements of used libraries by a link to external-libraries.txt
  • external links open in browser
  • preview of link in status bar

Future work: Write a script converting external-libraries.txt to the About.html files. Thereby, the concrete license files of each library have to be put into the About.html files, too.

@koppor koppor mentioned this pull request Oct 25, 2015
9 tasks
@simonharrer

Copy link
Copy Markdown
Contributor

👍 Especially not having to translate the used libraries section is really helpful, I think. And only linking instead of shipping everything with it.

@koppor

koppor commented Oct 25, 2015

Copy link
Copy Markdown
Member Author

After discussing, we should create a folder licenses, where each license file is stored with id.txt, where id is the id from external-libraries.txt. Then the build script should create the About.html txt content based on external-libraries.txt. Then, this conforms to the requirements of the BSD license.

@koppor koppor force-pushed the about_file_improvements branch from 427171c to 0f0dd06 Compare October 25, 2015 19:22
@koppor koppor changed the title Improve About.html files [WIP] Improve About.html files Oct 25, 2015
…nses/*.txt

 * refine format of external-libraries.txt
 * fix indent in About.html files
@koppor koppor changed the title [WIP] Improve About.html files Improve About.html files Oct 25, 2015
@koppor

koppor commented Oct 25, 2015

Copy link
Copy Markdown
Member Author

22c809c adds license information in licenses/ and reproduces that information in About.html. Thus, we should comply with the license requirements.

# Conflicts:
#	src/main/resources/help/de/About.html
#	src/main/resources/help/en/About.html
#	src/main/resources/help/fr/About.html
koppor added a commit that referenced this pull request Oct 26, 2015
@koppor koppor merged commit 2f76b5a into master Oct 26, 2015
@koppor koppor deleted the about_file_improvements branch October 26, 2015 01:08
koppor pushed a commit that referenced this pull request Apr 15, 2022
d834200f65 Merge pull request #257 from citation-style-language/dependabot/bundler/nokogiri-1.13.4
98d4f5b752 Bump nokogiri from 1.12.5 to 1.13.4
29ba8fa83d Merge pull request #256 from fflamerie/patch-1
0561735efd BCE/CE translations
beae92f5e0 Update locales-fr-FR.xml
4a353072f6 update for 1.0.2

git-subtree-dir: buildres/csl/csl-locales
git-subtree-split: d834200f65fabef95fda9e93144f76a1f62dd649
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants