Remove some UnicodeToLatex uses#2132
Merged
Merged
Conversation
lenhard
suggested changes
Oct 7, 2016
lenhard
left a comment
Member
There was a problem hiding this comment.
Good idea! This might improve performance a little and you also performed some cleanups that I forgot.
I have one minor remark, but otherwise the PR is fine.
| private static String removeLaTeX(String text) { | ||
| String result; | ||
| // remove braces | ||
| result = new RemoveBracesFormatter().format(text); |
Member
There was a problem hiding this comment.
This also removes the RemoveBracesFormatter, which is not part of the computation of latex-free fields. So, if I understand the code correctly, this changes functionality.
Contributor
Author
There was a problem hiding this comment.
I re-added it, but I don't know if its important. The latex-free field and the removeBraces are only used in the validation method, in the findDOI method the normal field is used.
Maybe someone has to look over it.
Member
There was a problem hiding this comment.
Agreed! At least for this PR, this is now good enough.
lenhard
approved these changes
Oct 7, 2016
Siedlerchr
added a commit
that referenced
this pull request
Oct 9, 2016
* upstream/master: (102 commits) Removed unused test code (#2140) Fix main table bug when creating a duplicate (#2135) Remove explicit author and add SPDX-License-Identifier Remove GPL from README.md and CONTRIBUTING.md fix preview update (#2125) Remove some UnicodeToLatex uses (#2132) Fix mixup in french/farsi localization FetcherException should extend JabRefException Fix exception when opening preference dialog (#2127) Unify ParserException and ParseException (#2124) Small refactoring in Importer package (#2053) Implement Datepicker "none"-button (#2122) revert change from 816d30c Change title/tooltip of source panel in biblatex mode (#2120) Refactoring: completey typed metadata and add detailed travis output (#2112) RTFchars fix (#2097) Fix NPE in Medline fetcher on missing ISSN (#2113) Ctrl-s parsing error message (#2114) Fix bad web search error messages (#2034) parse error freeze (#2106) ... # Conflicts: # src/main/java/net/sf/jabref/collab/FileUpdateMonitor.java # src/main/java/net/sf/jabref/gui/externalfiles/DownloadExternalFile.java # src/main/java/net/sf/jabref/gui/externalfiles/DroppedFileHandler.java # src/main/java/net/sf/jabref/gui/externalfiles/MoveFileAction.java # src/main/java/net/sf/jabref/logic/cleanup/RenamePdfCleanup.java # src/main/java/net/sf/jabref/logic/exporter/FileSaveSession.java # src/main/java/net/sf/jabref/logic/util/io/FileUtil.java # src/main/java/net/sf/jabref/preferences/JabRefPreferences.java
zesaro
pushed a commit
to zesaro/jabref
that referenced
this pull request
Nov 22, 2016
* remove some UnicodeToLatex uses * readd removeBracesFormatter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I removed some uses of the
UnicodeToLatexFormatterand used the latexFreeField directly.