Skip to content

Change title/tooltip of source panel in biblatex mode#2120

Merged
lenhard merged 4 commits into
masterfrom
source-panel-biblatex
Oct 5, 2016
Merged

Change title/tooltip of source panel in biblatex mode#2120
lenhard merged 4 commits into
masterfrom
source-panel-biblatex

Conversation

@lenhard

@lenhard lenhard commented Oct 5, 2016

Copy link
Copy Markdown
Member

This is a minor change to the source panel, which used to always display "BibTeX source" as title and a similar tooltip. Now, that is dependent on the mode of the database and reads "BibLaTeX source" in biblatex mode.

  • Change in CHANGELOG.md described
  • Manually tested changed features in running JabRef
  • If you changed the localization: Did you run gradle localizationUpdate?

@lenhard lenhard added [outdated] type: enhancement component: ui status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers labels Oct 5, 2016
@lenhard lenhard merged commit 9182175 into master Oct 5, 2016
Shortcut=

Show/edit_BibTeX_source=
Show/edit_%0_source=Montrer/�diter_le_source_BibTeX

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. this file is not in utf-8 thus the é makes problems with the python script (it should make problems with JabRef too as they're loaded with utf-8 in Java)
  2. isn't this french?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, I copied this into the wrong language file... Thanks a lot for spotting!

I will fix this directly on master, but I am actually not sure what to do with the UTF-8 problem. I copied the string from the french localization file. Do encodings differ between the localization files?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They all should be UTF-8.

@chriba chriba Oct 6, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly they do differ! (although JabRef ignores them and loads them all with utf-8)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lenhard Can you change the encoding of the farsi file? Should be no problem there are no translations in this file.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See 85baf0b At least that resolves the mixup. I am not sure about the encoding. At least I opened the file in notepad++ (which recognized it as utf-8), clicked "convert to utf-8", and saved it. Hopefully that worked.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And make sure that it's UTF-8 without BOM..

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Siedlerchr: should be. At least that is how my notepad recognizes it and how I saved it. There is another option "UTF-8 with BOM", which I did not select.

Siedlerchr added a commit that referenced this pull request Oct 9, 2016
* upstream/master: (102 commits)
  Removed unused test code (#2140)
  Fix main table bug when creating a duplicate (#2135)
  Remove explicit author and add SPDX-License-Identifier
  Remove GPL from README.md and CONTRIBUTING.md
  fix preview update (#2125)
  Remove some UnicodeToLatex uses (#2132)
  Fix mixup in french/farsi localization
  FetcherException should extend JabRefException
  Fix exception when opening preference dialog (#2127)
  Unify ParserException and ParseException (#2124)
  Small refactoring in Importer package (#2053)
  Implement Datepicker "none"-button (#2122)
  revert change from 816d30c
  Change title/tooltip of source panel in biblatex mode (#2120)
  Refactoring: completey typed metadata and add detailed travis output (#2112)
  RTFchars fix (#2097)
  Fix NPE in Medline fetcher on missing ISSN (#2113)
  Ctrl-s parsing error message (#2114)
  Fix bad web search error messages (#2034)
  parse error freeze (#2106)
  ...

# Conflicts:
#	src/main/java/net/sf/jabref/collab/FileUpdateMonitor.java
#	src/main/java/net/sf/jabref/gui/externalfiles/DownloadExternalFile.java
#	src/main/java/net/sf/jabref/gui/externalfiles/DroppedFileHandler.java
#	src/main/java/net/sf/jabref/gui/externalfiles/MoveFileAction.java
#	src/main/java/net/sf/jabref/logic/cleanup/RenamePdfCleanup.java
#	src/main/java/net/sf/jabref/logic/exporter/FileSaveSession.java
#	src/main/java/net/sf/jabref/logic/util/io/FileUtil.java
#	src/main/java/net/sf/jabref/preferences/JabRefPreferences.java
@stefan-kolb stefan-kolb deleted the source-panel-biblatex branch October 19, 2016 13:04
zesaro pushed a commit to zesaro/jabref that referenced this pull request Nov 22, 2016
* Source tab display "BibLaTeX source" when using biblatex mode

* More flexible localization

* Simplify control-flow

* Make localization mode-dependent in TextInputDialog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: ui [outdated] type: enhancement status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants