Implemented Integrity NoBibtexFieldChecker#2059
Merged
Merged
Conversation
added 2 commits
September 25, 2016 10:33
Siedlerchr
requested changes
Sep 25, 2016
Siedlerchr
left a comment
Member
There was a problem hiding this comment.
Please fix the copy and paste errors and think about the rewording
|
|
||
|
|
||
| public NoBibtexFieldChecker(BibDatabaseContext bibDatabaseContext) { | ||
| this.bibDatabaseContextEdition = Objects.requireNonNull(bibDatabaseContext); |
Member
There was a problem hiding this comment.
To make copy and paste easier: Just rename the variable to bibDatabseContext.
| //BibTeX | ||
| if (!bibDatabaseContextEdition.isBiblatexMode() && value.isPresent()) { | ||
| return Collections.singletonList( | ||
| new IntegrityMessage(Localization.lang("no BibTeX field"), entry, FieldName.JOURNALTITLE)); |
Member
There was a problem hiding this comment.
Maybe it is better to reword it and say: BibLaTeX field only?
| } | ||
|
|
||
| /** | ||
| * BibLaTeX package documentation (Section 4.9.1): |
Contributor
Author
|
Done. |
Member
|
Good! I merge it in! |
Siedlerchr
added a commit
that referenced
this pull request
Sep 25, 2016
* upstream/master: Implemented Integrity NoBibtexFieldChecker (#2059) Implemented title and camel key modifiers (#1894) Fix localization task hints (#2031) Result of syncLang.py update Result of syncLang.py update (with manual correction of captial_letters, and The_BibTeX_entry...) Fix "large capitals" to "capital letters" Updated Menu_tr.properties (#2057) Updated jabref_tr.properties (#2056) fix ignore version (#2055) Towards hierarchical keywords (#1950) Fix failing test, replace \uxxx encoded chars with proper UTF8 chars. Import Italian patch
zesaro
pushed a commit
to zesaro/jabref
that referenced
this pull request
Nov 22, 2016
* No BibTeX field * CHANGELOG.md * Correction 1 * Correction 2 (message) * Correction 3
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background: Converting to Biblatex format changes journal to journaltitle. Because journaltitle is a Biblatex field only, Integrity check now reports a problem for a journaltitle field in a BibTeX mode database.