Skip to content

Fix ignore version#2055

Merged
Siedlerchr merged 1 commit into
JabRef:masterfrom
chriba:fixIgnoreVersion
Sep 24, 2016
Merged

Fix ignore version#2055
Siedlerchr merged 1 commit into
JabRef:masterfrom
chriba:fixIgnoreVersion

Conversation

@chriba

@chriba chriba commented Sep 24, 2016

Copy link
Copy Markdown
Contributor

Fixes #2054

Made a rookie mistake and ignored the already ignored version again.
Reworked the preferences to the new design.

@Siedlerchr Siedlerchr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. When tests are green we can mergei t

@chriba

chriba commented Sep 24, 2016

Copy link
Copy Markdown
Contributor Author

The only test that failed is the getByDoi test from the springer service.
Not surprising since the Springer service is currently down for maintenance.

@Siedlerchr Siedlerchr merged commit 50da306 into JabRef:master Sep 24, 2016
@Siedlerchr

Copy link
Copy Markdown
Member

Okay, I merged it in!

@chriba chriba deleted the fixIgnoreVersion branch September 24, 2016 19:17
Siedlerchr added a commit that referenced this pull request Sep 25, 2016
* upstream/master:
  Implemented Integrity NoBibtexFieldChecker (#2059)
  Implemented title and camel key modifiers (#1894)
  Fix localization task hints (#2031)
  Result of syncLang.py update
  Result of syncLang.py update (with manual correction of captial_letters, and The_BibTeX_entry...)
  Fix "large capitals" to "capital letters"
  Updated Menu_tr.properties (#2057)
  Updated jabref_tr.properties (#2056)
  fix ignore version (#2055)
  Towards hierarchical keywords (#1950)
  Fix failing test, replace \uxxx encoded chars with proper UTF8 chars.
  Import Italian patch
zesaro pushed a commit to zesaro/jabref that referenced this pull request Nov 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants