Skip to content

Removed one Globals call from MetaData#1782

Merged
oscargus merged 1 commit into
JabRef:masterfrom
oscargus:keypattern
Aug 23, 2016
Merged

Removed one Globals call from MetaData#1782
oscargus merged 1 commit into
JabRef:masterfrom
oscargus:keypattern

Conversation

@oscargus

Copy link
Copy Markdown
Contributor

One further step towards a Globals-free MetaData.

@oscargus oscargus added status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers architecture labels Aug 19, 2016
@oscargus oscargus changed the title Remomved one Globals call from MetaData Removed one Globals call from MetaData Aug 19, 2016

public String getDefaultBibtexKeyPattern() { return defaultBibtexKeyPattern;}


Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate empty line. @koppor is this caused by our Eclipse Settings? I'm seeing that all the time.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is probably my bad, although I know sometimes Eclipse add double empty lines.

@stefan-kolb

Copy link
Copy Markdown
Member

Minor Comments otherwise LGTM 👍

@oscargus oscargus merged commit 2a1331e into JabRef:master Aug 23, 2016
Siedlerchr added a commit to Siedlerchr/jabref that referenced this pull request Aug 24, 2016
* master:
  Some more Swedish translations (JabRef#1836)
  Updated Menu_tr.properties
  Updated jabref_tr.properties
  Add check for obsolete database structure. Add help popup. (JabRef#1818)
  Updated dependencies (JabRef#1831)
  Removed one Globals call from MetaData (JabRef#1782)
Siedlerchr added a commit that referenced this pull request Aug 24, 2016
* master:
  Some more Swedish translations (#1836)
  Updated Menu_tr.properties
  Updated jabref_tr.properties
  Add check for obsolete database structure. Add help popup. (#1818)
  Updated dependencies (#1831)
  Removed one Globals call from MetaData (#1782)
ayanai1 pushed a commit to ayanai1/jabref that referenced this pull request Sep 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants