Add check for obsolete database structure. Add help popup.#1818
Conversation
|
|
||
| /** | ||
| * This exception is thrown in case that the shared database is not compatible with the current shared database support mechanisms. | ||
| * See JavaDoc of the field <code>VERSION</code> in {@link DBMSProcessor}. |
There was a problem hiding this comment.
Please use @link and # - see http://stackoverflow.com/a/1521318/873282
There was a problem hiding this comment.
Done. (removed old comment)
| JLabel migrationLabel = new JLabel(migrationMessage); | ||
| migrationLabel.setAlignmentX(Component.LEFT_ALIGNMENT); | ||
|
|
||
| String helpMessage = Localization.lang("Klick here to learn about the migration of old databases."); |
|
Shouldn't all of the migration stuff go into our migrations package? WDYT? |
|
This is only a migration "warning". There are no real migrating functions. Therefore I think it's OK to leave it here. Or are there some other opinions? |
| callHelpPage(); | ||
| } | ||
|
|
||
| private void callHelpPage() { |
f656368 to
3b12e8a
Compare
- Add getter method for HelpLabel - Add new class MigrationHelpDialog - Reorganize OpenSharedDatabaseDialog for OpenSharedDatabaseDialog - Extract checkTableAvailibility(...) and add checkOldIntergrity() - Add new class DatabaseNotSupportedException - Add localization entries
3b12e8a to
0b3da9b
Compare
| JLabel migrationLabel = new JLabel(migrationMessage); | ||
| migrationLabel.setAlignmentX(Component.LEFT_ALIGNMENT); | ||
|
|
||
| String helpMessage = Localization.lang("Click here to learn about the migration of pre-3.6 databases."); |
There was a problem hiding this comment.
The error message should mention "JabRef version 3.6" so that even less experienced JabRef users know what it means.
There was a problem hiding this comment.
If I mention 3.6, so this code would have to be updated after every version increment. "Click here to learn about the migration of pre-3.6 databases into current JabRef version"? WDYT? I think it's still bad.
There was a problem hiding this comment.
Since the db structure did only change with v 3.6, you can always write, that the error occured because of a database with the structure used in JabRef with a version < 3.6. It will always be true and does not need an updated version number.
There was a problem hiding this comment.
Now I think we should keep it general. Like "Click here to learn about a suitable database migration.", cause it's only a link to a help page. The help page describes exactly the reason and the solution. WDYT?
There was a problem hiding this comment.
Ok i see the information on the help page is detailed enough. LGTM then!
0b3da9b to
c7d3972
Compare
Issue: #1747
Tests for help.jabref.org may fail while https://github.com/JabRef/help.jabref.org/pull/56 is not merged.Screenshots:
