Skip to content

Auto detect user language #177#178

Merged
koppor merged 4 commits into
masterfrom
default-lang
Sep 25, 2015
Merged

Auto detect user language #177#178
koppor merged 4 commits into
masterfrom
default-lang

Conversation

@stefan-kolb

Copy link
Copy Markdown
Member

JabRef now uses the system locale as default with this PR.

I simplified some methods in the process and implemented a fallback to "en" when there is no bundle for the default locale.

Any suggestions?

@matthiasgeiger

Copy link
Copy Markdown
Member

👍
Should we clarify in the wiki that a new translation requires all three properties files (even if no keys are translated)?

@mlep This might be good to know for you, too.

@mlep

mlep commented Sep 25, 2015

Copy link
Copy Markdown
Contributor

Noted!
I can be the one adding it to the wiki if you want.

@matthiasgeiger

Copy link
Copy Markdown
Member

Okay, thank you!

koppor added a commit that referenced this pull request Sep 25, 2015
@koppor koppor merged commit 7fc7fb3 into master Sep 25, 2015
@stefan-kolb stefan-kolb deleted the default-lang branch September 29, 2015 09:19
@mlep

mlep commented Oct 1, 2015

Copy link
Copy Markdown
Contributor

Reading the wiki, it seems clear to me that the "Step-by-Step guide" (using Popeye) states that the 3 files must be created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants