Skip to content

Export to Office 2007#1765

Merged
Siedlerchr merged 6 commits into
masterfrom
office07
Aug 25, 2016
Merged

Export to Office 2007#1765
Siedlerchr merged 6 commits into
masterfrom
office07

Conversation

@Siedlerchr

@Siedlerchr Siedlerchr commented Aug 17, 2016

Copy link
Copy Markdown
Member

First fix for #1750.
I will continue reworking some other fields, too and will add some more tests.

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

@@ -0,0 +1,15 @@
% Encoding: UTF-8

@InBook{Orlowski;2011,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please name the test files after what they do and minimize them, not like the Stupro did just enumerating them 😄

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Aug 23, 2016
@Siedlerchr

Copy link
Copy Markdown
Member Author

I would like to merge this in for 3,6 (No Localization changes), after I rebase

Remove empty line in changelog

Fix failing test and add new test file

Issue gets exported as issue
Journaltitle and journal both get exoprted as JournalName
patennumber gets exported correctly

Fix checkstyle

Create better structure for import test
TODO: Fix import of journal!

Importer maps to biblatex fields for most fields
JournalName maps to journaltitle
Month can be imported and exported
Patentnumber gets importerd as number when the entryType is a patent
Remove msbib-patentnumber
Correct tests, use utf8 encoding

Create new file for empty test to avoid conflict with other imports

Use Latex2Unicode formatter for Author names, too
Search/split "and" in authors field case insenstive

Some code cleanups
Use more optionals

Export number as issue, when issue field not present
Rework some test files

Removed some Globals, reworked Tests
Day is MSBib only
Make Language methods deprecated
@Siedlerchr Siedlerchr changed the title [WIP] Export to Office 2007 Export to Office 2007 Aug 23, 2016
@koppor koppor added this to the v3.6 milestone Aug 24, 2016
Comment thread CHANGELOG.md Outdated

- Fixed [#1750](https://github.com/JabRef/jabref/issues/1750): BibLaTeX `date` field is now correctly exported as `year` in MS-Office 2007 xml format
- Fixed: LaTeX characters in author names are now converted to Unicode before export in MS-Office 2007 xml format
- Fixed: `Volume`, `Journaltitle`, `Issue` and `number`(for Patents) fields are now exported correctly in MS-Office 2007 xml format

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all field names in lower case. Space after number. Patents with lower case "p"

@oscargus

Copy link
Copy Markdown
Contributor

Looks good! Just some minor comments.

@Siedlerchr

Copy link
Copy Markdown
Member Author

I will fix it this afternoon/evening. Regarding the language mapping, there is not yet a simple solution, as we would have to integrate the whole table of LCID:

https://msdn.microsoft.com/de-de/goglobal/bb964664.aspx
https://support.office.com/en-us/article/Locale-identification-numbers-for-language-specific-files-16102229-37c5-4ad5-92b1-0438f6304114?ui=en-US&rs=en-US&ad=US

}

if(entry.journalName != null)
{

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{ in line above

* master:
  Some more Swedish translations (#1836)
  Updated Menu_tr.properties
  Updated jabref_tr.properties
  Add check for obsolete database structure. Add help popup. (#1818)
  Updated dependencies (#1831)
  Removed one Globals call from MetaData (#1782)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants