Translate the English "change to Chinese(simplified)" to the Chinese in the warning dialog by YuKiAndrew · Pull Request #14690 · JabRef/jabref

YuKiAndrew · 2025-12-22T22:28:44Z

User description

translate the English "change to Chinese (simplified)" to the Chinese in the warning dialog after clicking the preference saving button when users want to switch language from English to simplified Chinese

Steps to test

Open the preference dialog

2. Choose Chinese Simplified language

3. Show the result after revise

Mandatory checks

I own the copyright of the code submitted and I license it under the MIT license
I manually tested my changes in running JabRef (always required)
[/] I added JUnit tests for changes (if applicable)
I added screenshots in the PR description (if change is visible to the user)
I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
[/] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

PR Type

Bug fix, Documentation

Description

Translate "Chinese (Simplified)" language name to Chinese in UI
Add Chinese translation for language change notification message
Update CHANGELOG with bug fix documentation

Diagram Walkthrough

flowchart LR
  A["Language enum display name"] -- "Update to Chinese" --> B["简体中文 (Chinese Simplified)"]
  C["Language change notification"] -- "Add Chinese translation" --> D["Changed language to %0 message"]
  E["CHANGELOG entry"] -- "Document fix" --> F["Issue #14654 resolved"]

File Walkthrough

Relevant files

Enhancement

Language.java `Translate Simplified Chinese language name to Chinese` jablib/src/main/java/org/jabref/logic/l10n/Language.java Changed `SIMPLIFIED_CHINESE` enum display name from "Chinese (Simplified)" to "简体中文 (Chinese Simplified)" Ensures the language selector shows Chinese text when Simplified Chinese is selected	+1/-1

Localization

JabRef_zh_CN.properties `Add Chinese translation for language change message` jablib/src/main/resources/l10n/JabRef_zh_CN.properties Added Chinese translation for "Changed language to %0" message key Provides localized notification text when users switch to Simplified Chinese language Fixes mixed Chinese/English text in restart dialog	+3/-1

Documentation

CHANGELOG.md `Document language dialog translation fix` CHANGELOG.md Added entry documenting the fix for issue Restart-required dialog message is mixed Chinese/English after switching to zh_CN #14654 Describes the resolution of mixed Chinese/English text in warning dialog Note: Contains typo "issure" instead of "issue"	+1/-1

… in the warning dialog after clicking the preference saving button when users want to switch language from English to simplified Chinese

qodo-code-review · 2025-12-22T22:29:14Z

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢	No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
⚪	🎫 No ticket provided Create ticket/issue
Codebase Duplication Compliance
⚪	Codebase context is not defined Follow the guide to enable codebase context checks.
Custom Compliance
🟢	Generic: Comprehensive Audit Trails Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Meaningful Naming and Self-Documenting Code Objective: Ensure all identifiers clearly express their purpose and intent, making code self-documenting Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Robust Error Handling and Edge Case Management Objective: Ensure comprehensive error handling that provides meaningful context and graceful degradation Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Error Handling Objective: To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Logging Practices Objective: To ensure logs are useful for debugging and auditing without exposing sensitive information like PII, PHI, or cardholder data. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Security-First Input Validation and Data Handling Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
Update

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

qodo-code-review · 2025-12-22T22:30:03Z

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
General	Improve UI consistency for languages Update the display name for `TRADITIONAL_CHINESE` to include its native script (`繁體中文`) for consistency with the change made to `SIMPLIFIED_CHINESE`. jablib/src/main/java/org/jabref/logic/l10n/Language.java [34-38] SIMPLIFIED_CHINESE("简体中文 (Chinese Simplified)", "zh_CN"), SPANISH("Español", "es"), SWEDISH("Svenska", "sv"), TAGALOG("Tagalog/Filipino", "tl"), -TRADITIONAL_CHINESE("Chinese (Traditional)", "zh_TW"), +TRADITIONAL_CHINESE("繁體中文 (Chinese Traditional)", "zh_TW"), Apply / Chat Suggestion importance[1-10]: 6 __ Why: This is a good suggestion that improves UI consistency by applying the same naming pattern introduced in the PR to a related language option.	Low
General	✅ ~~Fix a typo in changelog~~ Suggestion Impact: The commit modified the exact changelog line containing the typo, but instead of correcting "issure" to "issue", it removed the entire entry (leaving a blank line). code diff: -- We fixed an issure where warning dialog is mixed Chinese/English after switching to zh_CN [#14654](https://github.com/JabRef/jabref/issues/14654) + Correct the typo "issure" to "issue" in the changelog entry. CHANGELOG.md [1739] -- We fixed an issure where warning dialog is mixed Chinese/English after switching to zh_CN [#14654](https://github.com/JabRef/jabref/issues/14654) +- We fixed an issue where warning dialog is mixed Chinese/English after switching to zh_CN [#14654](https://github.com/JabRef/jabref/issues/14654) `[Suggestion processed]` Suggestion importance[1-10]: 4 __ Why: The suggestion correctly identifies and fixes a typo in the changelog, which improves the quality and professionalism of the documentation.	Low
Update

Siedlerchr

How can one make so many mistakes in such a small PR?

Siedlerchr · 2025-12-22T22:35:02Z

 - We fixed an issue when importing resulted in an exception [#7343](https://github.com/JabRef/jabref/issues/7343)
 - We fixed an issue where the field in the Field formatter dropdown selection were sorted in random order. [#7710](https://github.com/JabRef/jabref/issues/7710)
-
+- We fixed an issure where warning dialog is mixed Chinese/English after switching to zh_CN [#14654](https://github.com/JabRef/jabref/issues/14654)


must to to the unrelased section

Siedlerchr · 2025-12-22T22:35:34Z


 Deprecated\ fields=废弃的字段

 Shows\ fields\ having\ a\ successor\ in\ biblatex.=Shows fields having a successor in biblatex.
-Shows\ fields\ having\ a\ successor\ in\ biblatex.\nFor\ instance,\ the\ publication\ month\ should\ be\ part\ of\ the\ date\ field.\nUse\ the\ Clean\ up\ Entries\ functionality\ to\ convert\ the\ entry\ to\ biblatex.=显示在biblatex中具有后继关系的field。\n例如，发布月份(publication month)应当是日期(date)的一部分。\n使用"清理记录"功能来转换条目为biblatex。 
+Shows\ fields\ having\ a\ successor\ in\ biblatex.\nFor\ instance,\ the\ publication\ month\ should\ be\ part\ of\ the\ date\ field.\nUse\ the\ Clean\ up\ Entries\ functionality\ to\ convert\ the\ entry\ to\ biblatex.=显示在biblatex中具有后继关系的field。\n例如，发布月份(publication month)应当是日期(date)的一部分。\n使用"清理记录"功能来转换条目为biblatex。


revert, see https://devdocs.jabref.org/code-howtos/localization.html why

Thank you for your reply, changing is on the way

…for-issue-14654_Restart_required_dialog_message_is_mixed_Chinese/English_after_switching_to_zh_CN # Conflicts: # jablib/src/main/resources/l10n/JabRef_zh_CN.properties

This reverts commit 04223cb.

…for-issue-14654_Restart_required_dialog_message_is_mixed_Chinese/English_after_switching_to_zh_CN

* main: Update AI usage policy (#14698) Fix handling of DOIs (#14704) Handle ohter CrossRef response (#14696) Fix condition for processing closed issues/PRs Translate the English "change to Chinese(simplified)" to the Chinese in the warning dialog (#14690) More performance optimization (#14695) Add missing dot (and a link) Add link to PR template also if checklist is present, but not OK (#14694) Fix typo in IntelliJ code style instructions (#14693) Add import into new library to Welcome Tab (#14669) Add initial search requirements (#14633)

YuKiAndrew added 2 commits December 22, 2025 12:15

translate the english "change to Chinese (simplified)" to the chinese…

1ca4237

… in the warning dialog after clicking the preference saving button when users want to switch language from English to simplified Chinese

translate the english "change to Chinese (simplified)" to the chinese…

b1335db

… in the warning dialog after clicking the preference saving button when users want to switch language from English to simplified Chinese

github-actions Bot added status: changes-required Pull requests that are not yet complete good first issue An issue intended for project-newcomers. Varies in difficulty. labels Dec 22, 2025

qodo-code-review Bot added the Review effort 1/5 label Dec 22, 2025

Siedlerchr requested changes Dec 22, 2025

View reviewed changes

YuKiAndrew added 7 commits December 22, 2025 14:44

fix the feedback of the PR

24e8a4d

Merge branch 'main' of https://github.com/YuKiAndrew/jabref into fix-…

8268092

…for-issue-14654_Restart_required_dialog_message_is_mixed_Chinese/English_after_switching_to_zh_CN # Conflicts: # jablib/src/main/resources/l10n/JabRef_zh_CN.properties

fix the feedback of the PR

04223cb

Revert "fix the feedback of the PR"

2850dad

This reverts commit 04223cb.

fix the feedback of the PR

58df067

Merge branch 'main' of https://github.com/YuKiAndrew/jabref into fix-…

9d9b048

…for-issue-14654_Restart_required_dialog_message_is_mixed_Chinese/English_after_switching_to_zh_CN

fix the feedback of the PR

496447f

github-actions Bot removed the status: changes-required Pull requests that are not yet complete label Dec 23, 2025

YuKiAndrew requested a review from Siedlerchr December 23, 2025 01:00

Siedlerchr approved these changes Dec 23, 2025

View reviewed changes

Siedlerchr added this pull request to the merge queue Dec 23, 2025

Merged via the queue into JabRef:main with commit e663a55 Dec 23, 2025
49 checks passed

github-actions Bot mentioned this pull request Dec 23, 2025

Restart-required dialog message is mixed Chinese/English after switching to zh_CN #14654

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Translate the English "change to Chinese(simplified)" to the Chinese in the warning dialog#14690

Translate the English "change to Chinese(simplified)" to the Chinese in the warning dialog#14690
Siedlerchr merged 9 commits into
JabRef:mainfrom
YuKiAndrew:fix-for-issue-14654_Restart_required_dialog_message_is_mixed_Chinese/English_after_switching_to_zh_CN

YuKiAndrew commented Dec 22, 2025 •

edited by qodo-code-review Bot

Loading

Uh oh!

qodo-code-review Bot commented Dec 22, 2025 •

edited

Loading

Uh oh!

qodo-code-review Bot commented Dec 22, 2025 •

edited

Loading

Uh oh!

Siedlerchr left a comment

Uh oh!

Siedlerchr Dec 22, 2025

Uh oh!

Siedlerchr Dec 22, 2025

Uh oh!

YuKiAndrew Dec 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

YuKiAndrew commented Dec 22, 2025 • edited by qodo-code-review Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

User description

Steps to test

Mandatory checks

PR Type

Description

Diagram Walkthrough

File Walkthrough

Uh oh!

qodo-code-review Bot commented Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Compliance Guide 🔍

Uh oh!

qodo-code-review Bot commented Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Code Suggestions ✨

Uh oh!

Siedlerchr left a comment

Choose a reason for hiding this comment

Uh oh!

Siedlerchr Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

Siedlerchr Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

YuKiAndrew Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

YuKiAndrew commented Dec 22, 2025 •

edited by qodo-code-review Bot

Loading

qodo-code-review Bot commented Dec 22, 2025 •

edited

Loading

qodo-code-review Bot commented Dec 22, 2025 •

edited

Loading