Changing the AI model in the preferences does not change the text of the status bar by sobinovskymatus · Pull Request #14053 · JabRef/jabref

sobinovskymatus · 2025-10-08T18:40:46Z

The problem was that when user set new ai model in preferences the info text in AI Chat doesn't change only after user switch to another entry then he see changes.
I remake function initializeNotice() in AiChatComponent class - now it binds noticeText.TextProperty() to a computed string using Bindings.createStringBinding() - that binding calls new function computeNoticeText() whenever any of the Observables returned by also new function noticeDependencies() change so the UI text auto-updates
new function computeNoticeText() - looks up the currently selected AI provider label and model from AiPreferences, then it builds string by taking the saved noticeTemplate and replacing the placeholder %0 with "provider model" (e.g. OpenAI gpt-4o-mini), then it returns final string for the binding to show in the UI.
new noticeDependencies() - lists of all observables properties that should trigger the recomputation of the notice, any change of these properties invalidates the binding which makes computeNoticeText() run again and refresh the text
Also i test for this functionality in new Test class AiChatComponentTest

Steps to test

Open JabRef, -> click on any entry -> click on "AI chat" -> down you can see that currently the "Open AI" "gpt-4o-mini" is set

2. Go to File -> Preferences -> AI -> and for example change "AI provider" to Gemini -> click "Save" -> now down in AI chat you can see that "Open AI" changes to "Gemini" and "gpt-4o-mini" changes to "gemini-1.5-flash" without need to click on another entry or refresh anything

Mandatory checks

I own the copyright of the code submitted and I license it under the MIT license
I manually tested my changes in running JabRef (always required)
I added JUnit tests for changes (if applicable)
I added screenshots in the PR description (if change is visible to the user)
I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

… properly / need to add test

…tus/jabref into fix-for-issue-13855

…tComponentTest.java Co-authored-by: Subhramit Basu <subhramit.bb@live.in>

calixtus · 2025-10-13T07:55:29Z

+        when(prefs.getAiProvider()).thenAnswer(_ -> providerProp.get());
+        when(prefs.getSelectedChatModel()).thenAnswer(_ -> {
+            return switch (providerProp.get()) {
+                case OPEN_AI ->
+                        openAiModelProp.get();
+                case MISTRAL_AI ->
+                        mistralModelProp.get();
+                case GEMINI ->
+                        geminiModelProp.get();
+                case HUGGING_FACE ->
+                        hfModelProp.get();
+                case GPT4ALL ->
+                        gpt4AllModelProp.get();
+            };
+        });


I think this is a bit nonsense. The answer of getSelectedChatModel() is ignored, instead you are looking up on a local variable providerProp, which is a few lines above set to OPEN_AI.
You could just make this a constant and abolish the switch, if i read this correctly.

I also change this one now -

calixtus · 2025-10-13T08:06:22Z

+        AiChatComponent component = createComponent(FXCollections.observableArrayList(), FXCollections.observableArrayList());
+
+        // Change provider
+        prefs.aiProviderProperty().set(provider);


You always set prefs to return OPEN_AI in the setup method

So this test is testing five times if OPEN_AI works.

This is what the test noticeTextUpdatesWhenProviderChanges() test -

So I dont think that this test is testing OPEN_AI five times every time this test runs it uses another provider from AiProvider class like you can see in the images i provide.

calixtus · 2025-10-13T08:11:55Z

+        // Set the provider and the corresponding model
+        prefs.aiProviderProperty().set(provider);
+        switch (provider) {
+            case OPEN_AI ->
+                    prefs.openAiChatModelProperty().set(newModel);
+            case MISTRAL_AI ->
+                    prefs.mistralAiChatModelProperty().set(newModel);
+            case GEMINI ->
+                    prefs.geminiChatModelProperty().set(newModel);
+            case HUGGING_FACE ->
+                    prefs.huggingFaceChatModelProperty().set(newModel);
+            case GPT4ALL ->
+                    prefs.gpt4AllChatModelProperty().set(newModel);
+        }


The switch is a bit useless imho, i dont see that in testing setting the model of another provider affects the tested provider. Set them up in the setup method. Then the enumsource can also be used.

And this is the second test with little changes -

and this is an output from test -

@calixtus is it okay now or should I do any other changes because honestly I dont know what else can I do in this class, but if you have some tips how to do it better fell free to write it.

calixtus · 2025-10-13T12:17:28Z

Ok, what i think whats causing my confusion is that the tests try to test two different things: On one hand if computeNoticeTest produces the correct text and on the other if the observables are triggering the computeNoticeTest method.

sobinovskymatus · 2025-10-13T12:27:23Z

@calixtus so what should i do now should i remake tests to only test that observables are triggering the computeNoticeTest method (because i think thats the main point what the output of this issue should be) or should i only test that computeNoticeTest produce the correct text or both can you please help me with this one so we can close this issue successfully? I think that we can do something like this we can create little function in test class getNoticeLabelText() which accesses the label (our notice text) via reflection

and then we do test like this for example where we dont call any function from AiChatComponent we only set for example new provider and then check if the label was changed something like this.
What do you think about it?

calixtus · 2025-10-13T18:42:47Z

ok, to move forward, we decided to merge in the state as is.

…the status bar (JabRef#14053) * changed initializeNotice() in AiChatComponent class / now should work properly / need to add test * add test for checking if the value of ai model is changing * changed CHANGELOG.md * deleted System.out from AiChatComponent.java * some changes in CHANGELOG.md * another changes in CHANGELOG.md * updates test for AiChatComponent class * CHANGELOG.md changes * edit CHANGELOG.md * update for tests in AiChatComponentTest class / update for function computeNoticeText() in AiChatComponent class * Fix submodules * Fix submodules * Update * Update csl-locales * Update submodules * Fix submodules * Update jabgui/src/test/java/org/jabref/gui/ai/components/aichat/AiChatComponentTest.java Co-authored-by: Subhramit Basu <subhramit.bb@live.in> * Update jabgui/src/test/java/org/jabref/gui/ai/components/aichat/AiChatComponentTest.java Co-authored-by: Subhramit Basu <subhramit.bb@live.in> * Update AiChatComponentTest.java * Update AiChatComponentTest.java - make som cleanup changes --------- Co-authored-by: Subhramit Basu <subhramit.bb@live.in>

sobinovskymatus and others added 4 commits October 7, 2025 22:06

changed initializeNotice() in AiChatComponent class / now should work…

0f033fa

… properly / need to add test

Merge branch 'JabRef:main' into main

0115ccf

add test for checking if the value of ai model is changing

8ee7ac7

changed CHANGELOG.md

c647d02

sobinovskymatus changed the title ~~Fix for issue 13855~~ Fix for issue 13855 #13855 Oct 8, 2025

sobinovskymatus changed the title ~~Fix for issue 13855 #13855~~ Fix for issue #13855 Oct 8, 2025

sobinovskymatus changed the title ~~Fix for issue #13855~~ Changing the AI model in the preferences does not change the text of the status bar Oct 8, 2025

deleted System.out from AiChatComponent.java

32b0405

Siedlerchr reviewed Oct 8, 2025

View reviewed changes

Comment thread CHANGELOG.md Outdated

Siedlerchr reviewed Oct 8, 2025

View reviewed changes

Comment thread CHANGELOG.md Outdated

sobinovskymatus added 2 commits October 8, 2025 21:02

some changes in CHANGELOG.md

f7ea758

another changes in CHANGELOG.md

79581f5

sobinovskymatus marked this pull request as ready for review October 8, 2025 19:22

sobinovskymatus requested a review from Siedlerchr October 8, 2025 19:43

calixtus requested changes Oct 9, 2025

View reviewed changes

Comment thread jabgui/src/test/java/org/jabref/gui/ai/components/aichat/AiChatComponentTest.java Outdated

Comment thread jabgui/src/test/java/org/jabref/gui/ai/components/aichat/AiChatComponentTest.java

sobinovskymatus and others added 5 commits October 10, 2025 14:17

Merge branch 'JabRef:main' into main

dc14786

Merge branch 'main' into fix-for-issue-13855

084e47f

updates test for AiChatComponent class

8fadb19

Merge branch 'fix-for-issue-13855' of https://github.com/sobinovskyma…

3de7325

…tus/jabref into fix-for-issue-13855

CHANGELOG.md changes

6788a75

calixtus reviewed Oct 10, 2025

View reviewed changes

Comment thread CHANGELOG.md Outdated

edit CHANGELOG.md

d88f8f7

sobinovskymatus requested a review from calixtus October 10, 2025 14:43

sobinovskymatus added 5 commits October 11, 2025 00:40

Merge branch 'main' into fix-for-issue-13855

c54e170

Merge branch 'main' into fix-for-issue-13855

35eb7ea

Merge branch 'main' into fix-for-issue-13855

bf05ffa

Merge branch 'main' into fix-for-issue-13855

d6f3b99

Merge branch 'main' into fix-for-issue-13855

0bbc9d2

Siedlerchr previously approved these changes Oct 12, 2025

View reviewed changes

sobinovskymatus added 4 commits October 12, 2025 22:15

Update

180c24b

Update csl-locales

31bcf12

Update submodules

06d9c52

Fix submodules

8f031c6

sobinovskymatus requested a review from calixtus October 12, 2025 20:43

subhramit reviewed Oct 12, 2025

View reviewed changes

Comment thread jabgui/src/test/java/org/jabref/gui/ai/components/aichat/AiChatComponentTest.java Outdated

subhramit reviewed Oct 12, 2025

View reviewed changes

Comment thread jabgui/src/test/java/org/jabref/gui/ai/components/aichat/AiChatComponentTest.java Outdated

subhramit reviewed Oct 12, 2025

View reviewed changes

Comment thread jabgui/src/test/java/org/jabref/gui/ai/components/aichat/AiChatComponentTest.java Outdated

sobinovskymatus and others added 3 commits October 13, 2025 00:16

Update jabgui/src/test/java/org/jabref/gui/ai/components/aichat/AiCha…

04c0055

…tComponentTest.java Co-authored-by: Subhramit Basu <subhramit.bb@live.in>

Update jabgui/src/test/java/org/jabref/gui/ai/components/aichat/AiCha…

6250cc1

…tComponentTest.java Co-authored-by: Subhramit Basu <subhramit.bb@live.in>

Update AiChatComponentTest.java

1b0185c

subhramit previously approved these changes Oct 12, 2025

View reviewed changes

subhramit added component: ui component: ai status: awaiting-second-review For non-trivial changes labels Oct 12, 2025

calixtus requested changes Oct 13, 2025

View reviewed changes

Update AiChatComponentTest.java - make som cleanup changes

a5216ea

sobinovskymatus dismissed subhramit’s stale review via a5216ea October 13, 2025 10:29

Merge branch 'main' into fix-for-issue-13855

f2930a0

sobinovskymatus requested a review from calixtus October 13, 2025 10:49

Siedlerchr enabled auto-merge October 13, 2025 18:42

calixtus approved these changes Oct 13, 2025

View reviewed changes

Siedlerchr added this pull request to the merge queue Oct 13, 2025

Merged via the queue into JabRef:main with commit 8ec4808 Oct 13, 2025
49 checks passed

github-actions Bot mentioned this pull request Oct 13, 2025

Changing the AI model in the preferences does not change the text of the status bar #13855

Closed

2 tasks

Uh oh!

Conversation

sobinovskymatus commented Oct 8, 2025

Steps to test

Mandatory checks

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

calixtus Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

sobinovskymatus Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

calixtus Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

sobinovskymatus Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

calixtus Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

sobinovskymatus Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

calixtus commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sobinovskymatus commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

calixtus commented Oct 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

calixtus commented Oct 13, 2025 •

edited

Loading

sobinovskymatus commented Oct 13, 2025 •

edited

Loading