Merge "Citation information" and "Citation relations" #13618 by Mitkens374 · Pull Request #14045 · JabRef/jabref

Mitkens374 · 2025-10-06T20:07:31Z

Merged "Citation information" into "Citation relations" tab, now called Citations. Removed old SciteTab and SciteTabViewModel classes, as their logic is now entirely in CitationRelationsTab and CitationRelationsTabViewModel respectively. Created new class ScienceAiFetcher, for fetching tallies from scite.ai, utilizing new TalliesResponse record.

Steps to test

Start JabRef
Open a library
Select an entry
Open the "Citations" tab, to see all the information from former "Citation information" tab.

Before:

After:

Mandatory checks

I own the copyright of the code submitted and I license it under the MIT license
I manually tested my changes in running JabRef (always required)
I added JUnit tests for changes (if applicable)
I added screenshots in the PR description (if change is visible to the user)
I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

…"Citations") and removed SciteTab from view in EntryEditor.

…method to new class ScienceAiFetcher.java. Moved SciteTallyModel to jabref.model.sciteTallies and renamed to TalliesResponse.

github-actions · 2025-10-06T20:07:42Z

Hey @Mitkens374!

Thank you for contributing to JabRef! Your help is truly appreciated ❤️.

We have automatic checks in place, based on which you will soon get automated feedback if any of them are failing.
We also use TragBot with custom rules that scans your changes and provides some preliminary comments, before a maintainer takes a look.
TragBot is still learning, and may not always be accurate.
In the "Files changed" tab, you can go through its comments and just click on "Resolve conversation" if you are sure that it is incorrect, or comment on the conversation if you are doubtful.

Please re-check our contribution guide in case of any other doubts related to our contribution workflow.

ThiloteE · 2025-10-06T20:29:53Z

Since this is GUI related, please provide screenshots of "Before" and "After".

calixtus

Hi, thank you for you PR, we really appreciate it. So far the changes to the code look mostly fine. I put some comments into.

Now we need to talk about the visuals... You designed it after the proposal in the issue description, functionally the important part is done. But the proposal in the issue is not good. Now it looks like everything is just stacked in top of each other.

Idea is: You sure want to indicate that these informations come from different sources: citation relations from semantic scholar and metrics from scite.ai.

Please make a proposal to make this look nice. Look at other software how they do it. Fetch some ideas from ui design forums.

calixtus · 2025-10-06T20:33:44Z

+    private static final String SEMANTIC_SCHOLAR_URL = "https://www.semanticscholar.org/";
+    private static final String SCITE_REPORTS_URL_BASE = "https://scite.ai/reports/";
+    private static final String SCITE_URL = "https://scite.ai/";
+


Please put the URL constants to the dedicated helper class URLs.

Mitkens374 · 2025-10-06T20:51:40Z

Thanks for the comments, I will start working on the needed changes. In the case of the "Source branch is other than "main"" check, should I close this request and make a new one with a correctly named branch?

calixtus · 2025-10-06T22:07:51Z

Thanks for the comments, I will start working on the needed changes. In the case of the "Source branch is other than "main"" check, should I close this request and make a new one with a correctly named branch?

No, just finish this one. But for next time, remember, that for creating a fix or a feature creating a new branch is git 101.

…ss. Added nicer styling to the Citations tab.

Mitkens374 · 2025-10-08T10:22:11Z

Hi, I have added the requested changes and also added some better styling to the tab. Later today I will also resolve the localization issues that are coming up.

If the styling of the tab is still inadequate any advice or ideas on how to make it nicer would be appreciated.

Here is how the tab looks currently:

calixtus · 2025-10-08T14:22:15Z

Imagine you were just an average user, you have no idea about java programming, scite.ai or semantic scholar. What information would the titles provide? The source of the information. Nice to know, but certainly not the title.
Use "citation relations" and "Citation metrics" or just "Relations" and "Metrics". Or make even the metrics less prominent.

Compare your design to other software. Good UI design is likewise important as the code itself and requires planning, effort and interest.

Siedlerchr · 2025-10-08T14:46:22Z

I would add just add a help button/tooltip opening a user documentation page explaining where the data is coming from.

…explaining the source and linking to the respective page.

Mitkens374 · 2025-10-08T20:20:30Z

Hi, I renamed the titles in the panel and added a help button linking to the respective pages (semanticscholar.org and scite.ai). The button also has a tooltip, explaining the source of the information.

Here is the current state, with the tooltip visible for the Citation Relations section:

ThiloteE · 2025-10-08T21:00:08Z

+    }
+
+    private VBox getMessageBox(String url, Text message) {
+        HyperlinkLabel link = new HyperlinkLabel(Localization.lang("See full report at [%0]", url));


I think "See full report" could be in the same line as the other info, right next to "Citing Publications". The url doesn't necessarily have to be shown to the user, as long as they can click somewhere that will lead them to the webpage, so just turn "See full report" into the link itself and it will be possible to remove the useless "at" and the url, thereby saving screenspace and making it a little bit more beautiful.

Hi, thanks for the idea. I have made the Citation Metrics section into a single line with the report link at the end. For better separation of the text, I broke up the former message into separate elements, which are added to the display with a " | " as a separator. This way the link in the last element always has the same spacing also.

Here is the current version:

Much better. And the longer I look at it, i think even the titles themselves can be abolished.
The title: "Metrics" could also sit in the same line as the metrics themselves ("Metrics: Total citations ...").
The "Citation Relations" title is imho superfluous as the table and the table headers should be self describing already.
Question is only, where should the help buttons / the proper credit to the information providers go?
Maybe somewhere also as a small hyperlink ("powered by semantic / scite")? Just thinking loud.
I know, titles are nice and many times, they are really important and needed. But in this case, I think "Citations" in the tab bar is already the best title.

In computer science, the hardest thing is naming things, in ui design, the hardest thing is where to place the names maybe.

Hi, I removed the labels, and I have put the "provided by" helper buttons at the bottom of the tab.

Here is the current state:

I think that the separation nicely indicates that the sources for the information are different and that the buttons are related to different parts of the tab. I changed the tooltip message as well to make it a bit more clear ("Metrics/Relations provided by...").

I am not entirely sure about the button next to the "See full report" as it may seem a bit redundant maybe? They pretty much link to the same site, but i think keeping the landing page link for scite.ai, somewehere in the tab is a good choice, as there is a lot of information about the service there. On the other hand maybe removing the helper button and adding the tooltip to the "See full report" link, explaining the source and only linking to the full report would make the tab even more clear. I'll let you be the judge of that :D.

I am okay with this now! LGTM

I like it too.

…ents to have better separation.

…entirely in the Metrics line.

Siedlerchr · 2025-10-09T21:21:50Z

Thanks a lot for your contribution and the quick changes!

Mitkens374 · 2025-10-09T22:00:45Z

Thank you for the opportunity and for all the notes about the design. UI design is not my strong suit (as you may have guessed :D) so I am very glad that I gained some experience in that field, and that in the end we managed to create something nice :D.

…abRef#14045) * Merged scite metrics tab into the Citation Relations Tab (now called "Citations") and removed SciteTab from view in EntryEditor. * Removed SciteTab.java and SciteTabViewModel.java. Moved fetchTallies method to new class ScienceAiFetcher.java. Moved SciteTallyModel to jabref.model.sciteTallies and renamed to TalliesResponse. * Added info to CHANGELOG.md. * CHANGELOG formatting. * Updated CHANGELOG.md after PR comments. Moved URLs to URLs helper class. Added nicer styling to the Citations tab. * Updated CHANGELOG.md after PR comments. Moved URLs to URLs helper class. Added nicer styling to the Citations tab. * Added missing localization keys and removed obsolete localization keys. * Added localization to citation tab labels * Renamed labels in Citations tab and added a help button with a popup explaining the source and linking to the respective page. * Updated Citation Metrics section to a single line * Made Citation Metrics a single line. Also broke up its text into elements to have better separation. * Removed labels in the Citations tab. The provided by buttons are now entirely in the Metrics line. --------- Co-authored-by: Mitkens374 <michal.leso@student.tuke.sk>

Mitkens374 and others added 8 commits September 30, 2025 13:03

Merged scite metrics tab into the Citation Relations Tab (now called …

b7f5ed0

…"Citations") and removed SciteTab from view in EntryEditor.

Merge branch 'JabRef:main' into main

8924db8

Merge branch 'JabRef:main' into main

9e7b8eb

Removed SciteTab.java and SciteTabViewModel.java. Moved fetchTallies …

3f65f8c

…method to new class ScienceAiFetcher.java. Moved SciteTallyModel to jabref.model.sciteTallies and renamed to TalliesResponse.

Added info to CHANGELOG.md.

5ac7c93

CHANGELOG formatting.

940e336

Merge branch 'JabRef:main' into main

82ed863

Merge branch 'JabRef:main' into main

87ca0e7

github-actions Bot added the first contrib label Oct 6, 2025

calixtus requested changes Oct 6, 2025

View reviewed changes

Merge branch 'main' into main

f442f33

Mitkens374 added 3 commits October 8, 2025 12:08

Updated CHANGELOG.md after PR comments. Moved URLs to URLs helper cla…

18def92

…ss. Added nicer styling to the Citations tab.

Updated CHANGELOG.md after PR comments. Moved URLs to URLs helper cla…

b75ef8f

…ss. Added nicer styling to the Citations tab.

Merge remote-tracking branch 'origin/main'

6497f28

Mitkens374 added 2 commits October 8, 2025 14:08

Added missing localization keys and removed obsolete localization keys.

fbbedd2

Added localization to citation tab labels

3acbecc

Mitkens374 requested a review from calixtus October 8, 2025 12:55

Renamed labels in Citations tab and added a help button with a popup …

8dc363a

…explaining the source and linking to the respective page.

ThiloteE reviewed Oct 8, 2025

View reviewed changes

Mitkens374 and others added 3 commits October 8, 2025 23:32

Updated Citation Metrics section to a single line

1cd5022

Made Citation Metrics a single line. Also broke up its text into elem…

c1f3f35

…ents to have better separation.

Merge branch 'main' into main

3687c38

Mitkens374 and others added 2 commits October 9, 2025 20:59

Removed labels in the Citations tab. The provided by buttons are now …

daa68b1

…entirely in the Metrics line.

Merge branch 'main' into main

ad503ca

calixtus approved these changes Oct 9, 2025

View reviewed changes

calixtus enabled auto-merge October 9, 2025 21:05

calixtus added this pull request to the merge queue Oct 9, 2025

Merged via the queue into JabRef:main with commit fdd6da3 Oct 9, 2025
48 of 49 checks passed

github-actions Bot mentioned this pull request Oct 9, 2025

Merge "Citation information" and "Citation relations" #13618

Closed

koppor mentioned this pull request Oct 29, 2025

Fix class name for SciteAiFetcher #14195

Merged

2 tasks

Uh oh!

Conversation

Mitkens374 commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Steps to test

Mandatory checks

Uh oh!

github-actions Bot commented Oct 6, 2025

Hey @Mitkens374!

Uh oh!

ThiloteE commented Oct 6, 2025

Uh oh!

calixtus left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

calixtus Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

Mitkens374 commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

calixtus commented Oct 6, 2025

Uh oh!

Mitkens374 commented Oct 8, 2025

Uh oh!

calixtus commented Oct 8, 2025

Uh oh!

Siedlerchr commented Oct 8, 2025

Uh oh!

Mitkens374 commented Oct 8, 2025

Uh oh!

ThiloteE Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Mitkens374 Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

calixtus Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

Mitkens374 Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Siedlerchr Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

calixtus Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

Siedlerchr commented Oct 9, 2025

Uh oh!

Uh oh!

Mitkens374 commented Oct 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Mitkens374 commented Oct 6, 2025 •

edited

Loading

Mitkens374 commented Oct 6, 2025 •

edited

Loading

ThiloteE Oct 8, 2025 •

edited

Loading

Mitkens374 Oct 9, 2025 •

edited

Loading