Skip to content

Add ADR-0050 on code formatter#13895

Merged
calixtus merged 2 commits into
mainfrom
add-adr-on-code-style
Sep 13, 2025
Merged

Add ADR-0050 on code formatter#13895
calixtus merged 2 commits into
mainfrom
add-adr-on-code-style

Conversation

@koppor

@koppor koppor commented Sep 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

This is the ADR for #13885.

Includes comments from

Other style PRs:

#10646

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • [/] I manually tested my changes in running JabRef (always required)
  • [/] I added JUnit tests for changes (if applicable)
  • [/] I added screenshots in the PR description (if change is visible to the user)
  • [/] I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
  • [/] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

@koppor koppor requested a review from calixtus September 13, 2025 20:08
@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Sep 13, 2025
@calixtus
Update custom code style decision with maintenance note
f0e33c7 
Added a note about the Eclipse formatter not being actively maintained.
@calixtus calixtus enabled auto-merge September 13, 2025 20:32
@trag-bot

trag-bot Bot commented Sep 13, 2025

Copy link
Copy Markdown

@trag-bot didn't find any issues in the code! ✅✨

github-actions[bot]
github-actions Bot reviewed Sep 13, 2025
View reviewed changes
Comment thread docs/decisions/0050-custom-code-style.md

* Bad, because [Markdown JavaDoc cannot be used](https://github.com/google/google-java-format/issues/1193)
* Bad, because [does not support `format:off` comments](https://github.com/google/google-java-format/issues/137).
* Bad, because not actively maintained; there are [139 opened issues](https://github.com/google/google-java-format/issues?q=sort%3Aupdated-desc%20is%3Aissue%20is%3Aopen&page=1).

@github-actions github-actions Bot Sep 13, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [linkspector] reported by reviewdog 🐶
Cannot reach https://github.com/google/google-java-format/issues?q=sort%3Aupdated-desc%20is%3Aissue%20is%3Aopen&page=1 Status: 429

@calixtus calixtus added this pull request to the merge queue Sep 13, 2025
Merged via the queue into main with commit 99411e7 Sep 13, 2025
40 of 41 checks passed
@calixtus calixtus deleted the add-adr-on-code-style branch September 13, 2025 20:49
Siedlerchr added a commit that referenced this pull request Sep 14, 2025
@Siedlerchr
Merge remote-tracking branch 'upstream/main'
e0909e6 
* upstream/main:
  Add hint on auto formatting (#13886)
  Add ADR-0050 on code formatter (#13895)
  Reformat codebase (more carefully) (#13885)
  New Crowdin updates (#13892)
  Fix record wrapping (#13889)
  Fix JavaDoc (#13888)
  Improve IntelliJ settings (#13887)
  Manual code reformattings (#13883)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@calixtus calixtus calixtus approved these changes

Assignees

No one assigned

Labels

project: jabcon status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@koppor @calixtus @subhramit