Skip to content

Use prettier-java#717

Closed
koppor wants to merge 45 commits into
mainfrom
use-prettier
Closed

Use prettier-java#717
koppor wants to merge 45 commits into
mainfrom
use-prettier

Conversation

@koppor

@koppor koppor commented Aug 19, 2025

Copy link
Copy Markdown
Member

Use prettier-java.

Seems to be maintained. And better than two years ago (this PR is a follow-up to JabRef#10646)

  • Automatic code update for maintainers (as a seperate step)
  • Failing test for non-maintainers

Notes:

Note on 80 chars

It seems to be well-thought of

It is not the hard upper allowed line length limit. It is a way to say to Prettier roughly how long you’d like lines to be.

image

Source: https://prettier.io/docs/options

Steps to test

  • Look at the diff
  • Edit a file

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • [/] Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • [/] Tests created for changes (if applicable)
  • [/] Manually tested changed features in running JabRef (always required)
  • [/] Screenshots added in PR description (if change is visible to the user)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • [/] Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@InAnYan

InAnYan commented Sep 13, 2025

Copy link
Copy Markdown
Member

Failing tests for non-maintainers??

What a privilege to be a maintainer 😆

@InAnYan

InAnYan commented Sep 13, 2025

Copy link
Copy Markdown
Member

Are there any clashes with how we organize imports?

@koppor

koppor commented Sep 13, 2025

Copy link
Copy Markdown
Member Author

Are there any clashes with how we organize imports?

We will follow the import guide of prettier-java - and ignore our wishes.

(I don't read imports, I just want to have them conflict-free)

WDYT?

@koppor

koppor commented Sep 13, 2025

Copy link
Copy Markdown
Member Author

Do we accept the issue jhipster/prettier-java#777 for now?

@InAnYan

InAnYan commented Sep 13, 2025

Copy link
Copy Markdown
Member

Oh, sorry, I deleted my message because mobile github messed up the history of conversation.

Tldr; accept everything as is

@InAnYan

InAnYan commented Sep 13, 2025

Copy link
Copy Markdown
Member

It's not ideal, but if it allows me to format and forget - then I will go for it

@koppor koppor mentioned this pull request Sep 13, 2025
1 task
@koppor koppor closed this Sep 13, 2025
@koppor

koppor commented Sep 13, 2025

Copy link
Copy Markdown
Member Author

We opted to continue with IntelliJ - JabRef#13885

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants