Automatic lookup of DOI at citation relations by ankamde · Pull Request #13539 · JabRef/jabref

ankamde · 2025-07-14T15:54:11Z

In the "Citation relations", if there is no DOI, offer a "link" to determine the DOI.

Steps to test

In the "{} biblatex source" add an article

@Article{,
author = {Oliver Kopp and Carl Christian Snethlage and Christoph Schwentker},
journal = {TUGboat},
title = {JabRef: BibTeX-based literature management software},
year = {2023},
issn = {0896-3207},
number = {3},
pages = {441--447},
volume = {44},
issue = {138},
ranking = {rank4},
}

"Citation relations" tab shows modified message with "Look up a DOI and try again." being a link on both panels.

Click on one of the "Look up a DOI and try again." - DOI look up will start.

After successful look up both panels are populated with the data (if exists).

"General" contains looked up DOI.

Negative tests

When DOI cannot be found, display a message to the user.

In case on an error - show message on the panels.

Mandatory checks

I own the copyright of the code submitted and I license it under the MIT license
Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
[/] Tests created for changes (if applicable)
Manually tested changed features in running JabRef (always required)
Screenshots added in PR description (if change is visible to the user)
Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

trag-bot · 2025-07-14T15:55:57Z

+        Button refreshButton,
+        CitationFetcher.SearchType searchType,
+        Button importButton,
+        ProgressIndicator progress) {


UI component (ProgressIndicator) should not be directly included in a data structure. This violates separation of concerns and should be managed in a dedicated UI controller.

This is simple parameter object - instead passing 7 parameters, use dedicated object.

trag-bot · 2025-07-14T15:56:52Z

+        ObservableList<CitationRelationItem> observableList = FXCollections.observableArrayList();
+        citationComponents.listView().setItems(observableList);
+
+        // TODO: It should not be possible to cancel a search task that is already running for same tab


Comment does not add new information and is just stating what should be done. TODO comments should be tracked in issue tracking system instead of code.

All TODO: comments were in this class before refactoring - I'm happy to add all 3 to issue tracking system but I think I don't have sufficient priviledges.

Why did you move things around? Makes things hard to review.

I grouped methods that collaborate. It was slightly difficult for me to navigate this class in the previous form.

koppor · 2025-07-15T06:24:31Z

@@ -2791,7 +2791,8 @@ Miscellaneous=Diversos
 File-related=Arquivo relacionado

 Add\ selected\ entry(s)\ to\ library=Adicionar as referências selecionadas à biblioteca


You have to go through crowdin web site to update translations....

OK, let me have a look.

When the PR is merged, the new translations will be synced with crowdin and you can translat them there https://crowdin.com/project/jabref

@koppor @Siedlerchr Could you raise an issue to address the new translations with Crowdin and assign it to me, please?

Do you need that for a university course? Typically Crowdin just works.

…ion-relations

trag-bot · 2025-07-16T14:18:35Z

+            hideNodes(citationComponents.abortButton(), citationComponents.progress(), citationComponents.importButton());
+            showNodes(citationComponents.refreshButton());
+            task.cancel();
+            dialogService.notify(Localization.lang("Search aborted!"));


Use of exclamation mark in UI text notification violates the guideline for avoiding exclamation marks at sentence endings in UI messages.

This message was here before I refactored this class. Looks like a valid notification to me.

You could change the localization string to Search aborted..

Happy to do this.

ankamde · 2025-07-16T14:23:26Z

@koppor @Siedlerchr This PR is ready for a review. Please have a look.

koppor

Minor comments

I need to start RefactoringMiner to be able really review the moved around methods.

koppor · 2025-07-16T14:25:49Z

+
+        HBox hBox = new HBox();
+        Label label = new Label(Localization.lang("The selected entry doesn't have a DOI linked to it."));
+        Hyperlink link = new Hyperlink(Localization.lang("Look Up a DOI and try again."));


We use sentence case in JabRef. Change Up to up. -- Also at the lines below.

koppor · 2025-07-16T14:26:54Z

+        ObservableList<CitationRelationItem> observableList = FXCollections.observableArrayList();
+        citationComponents.listView().setItems(observableList);
+
+        // TODO: It should not be possible to cancel a search task that is already running for same tab


Why did you move things around? Makes things hard to review.

ankamde · 2025-07-16T16:02:05Z

@koppor I've addressed all of the comments. Please have a look.

trag-bot · 2025-07-18T14:23:15Z

@trag-bot didn't find any issues in the code! ✅✨

koppor

I checked the diff in Refactoring Miner - and also tried it out.

Looks good.

* Some initial changes + split of the placeholder to label and hyperlink. * Commit before switching to different branch. * Cited by panel ready. * Cited by panel ready. * Finished DOI lookup, add notification about not found DOI. * Add messages to JabRef_en.properties. Modified lang files rolled back. * Change "Up" to "up" in the messages. * Remove exclamation from the message. * Move methods to the original place in the file.

* upstream/main: Bump jablib/src/main/resources/csl-locales from `3bad433` to `ea1b54f` (#13565) New Crowdin updates (#13562) Add a new field for citation count (#13531) Automatic lookup of DOI at citation relations (#13539) Update dependency com.konghq:unirest-modules-gson to v4.5.0 (#13557) Group tab is now empty when there are no libraries open (#13473)

ankamde added 5 commits July 12, 2025 14:09

Some initial changes + split of the placeholder to label and hyperlink.

ec864d3

Commit before switching to different branch.

365b4fa

Cited by panel ready.

a24dd53

Cited by panel ready.

4ef4dd4

Finished DOI lookup, add notification about not found DOI.

af8b918

trag-bot Bot reviewed Jul 14, 2025

View reviewed changes

koppor reviewed Jul 15, 2025

View reviewed changes

ankamde added 2 commits July 16, 2025 16:15

Add messages to JabRef_en.properties. Modified lang files rolled back.

5fa2d72

Merge branch 'main' into issue-13234-automatic-lookup-of-DOI-at-citat…

927664c

…ion-relations

trag-bot Bot reviewed Jul 16, 2025

View reviewed changes

ankamde marked this pull request as ready for review July 16, 2025 14:22

koppor requested changes Jul 16, 2025

View reviewed changes

ankamde added 2 commits July 16, 2025 16:32

Change "Up" to "up" in the messages.

dfdec86

Remove exclamation from the message.

43e1ce7

ankamde changed the title ~~Issue 13234 automatic lookup of doi at citation relations~~ Issue 13234 automatic lookup of DOI at citation relations Jul 16, 2025

ankamde requested review from Siedlerchr and koppor July 17, 2025 07:24

Move methods to the original place in the file.

487e1fb

calixtus changed the title ~~Issue 13234 automatic lookup of DOI at citation relations~~ Automatic lookup of DOI at citation relations Jul 19, 2025

koppor enabled auto-merge July 20, 2025 22:43

koppor approved these changes Jul 20, 2025

View reviewed changes

koppor added this pull request to the merge queue Jul 20, 2025

Merged via the queue into JabRef:main with commit e1d0d66 Jul 20, 2025
1 check passed

github-actions Bot mentioned this pull request Jul 20, 2025

Automatic lookup of DOI at citation relations #13234

Closed

koppor mentioned this pull request Jul 21, 2025

Automatic lookup of DOI at "Citation information" #13561

Closed

		@@ -2791,7 +2791,8 @@ Miscellaneous=Diversos
		File-related=Arquivo relacionado

		Add\ selected\ entry(s)\ to\ library=Adicionar as referências selecionadas à biblioteca

Uh oh!

Conversation

ankamde commented Jul 14, 2025 • edited by Siedlerchr Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Steps to test

Negative tests

Mandatory checks

Uh oh!

trag-bot Bot Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

trag-bot Bot Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

trag-bot Bot Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ankamde commented Jul 16, 2025

Uh oh!

koppor left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ankamde commented Jul 16, 2025

Uh oh!

trag-bot Bot commented Jul 18, 2025

Uh oh!

koppor left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ankamde commented Jul 14, 2025 •

edited by Siedlerchr

Loading