Add a new field for citation count#13531
Conversation
| // JabRef-specific fields | ||
| GROUPS("groups"), | ||
| OWNER("owner"), | ||
| CITATIONCOUNT("Citation count"), |
There was a problem hiding this comment.
Field name should be in lowercase with underscores for consistency with other field names. The display name should be sentence case as per UI text guidelines.
koppor
left a comment
There was a problem hiding this comment.
The space in the field name is strange.
An additional test (writing BibTeX and trying to read it) would have discoved it. However, too much effort for the gain. I fixed it.
I also parsed the error field and display it to the user at deee352 (#13531)
"Funny" DOI is 10.1145/1028174.971312, where no citation count is available, but the tab "Citation information" shows the count.
We will create a follow up issue (internal link https://github.com/JabRef/jabref-issue-melting-pot/issues/995).
I will let this through to move forward.
| // JabRef-specific fields | ||
| GROUPS("groups"), | ||
| OWNER("owner"), | ||
| CITATIONCOUNT("Citation count"), |
|
@trag-bot didn't find any issues in the code! ✅✨ |
|
thks @koppor !!! i saw you are going to open a deffect, plase feel free to consider me in resolving, i will appreciate it |
|
@SalvadorRomo Thank you! Just grab the issue if you feel comfortable working with. I currently don't have the capacity to do a deep management... |
* first changes * partial change * add fields to GUI * finish change * fix citation count identifier * adding tests * add more testing * remove unwanted logic * add entry to change log * resolve comments * resolve comments * resolve conflicts * enhance citation count change log * enhance citation count change log * change assertion style * resolve conflicts * resolve conflicts * resolve conflicts * resolve test errors * resolve conflicts * fix branch * fix test * remove unused class * resolve comment * Update CHANGELOG.md Co-authored-by: Oliver Kopp <kopp.dev@gmail.com> * resolve comments * fix comments * fix comments * fix comments * fix issues * fix comments * remove unused import * fix comments * fix test cases * fix comments * fix tests * Fix space in fieldname * Use "error" from server for notification of error * Fix requires for xmlunit * Ensure that streams are closed during test * Fix test file * Fix OpenRewrite --------- Co-authored-by: Oliver Kopp <kopp.dev@gmail.com> Co-authored-by: Salvador Romo <salvadorromo@MacBook-Air-de-Salvador.local>
* upstream/main: Bump jablib/src/main/resources/csl-locales from `3bad433` to `ea1b54f` (#13565) New Crowdin updates (#13562) Add a new field for citation count (#13531) Automatic lookup of DOI at citation relations (#13539) Update dependency com.konghq:unirest-modules-gson to v4.5.0 (#13557) Group tab is now empty when there are no libraries open (#13473)
Closes #13477
This PR add a new filed in the General Count to fetch the citationCount for a given Entry, with the ability to look it up.
Steps to test
1- Add a new paper
2- Go to the General Tab and
3 - Place your cursor in the new Citation Field
4- next to the field, there is button available to start the search
5- if the value is blank or the TTL for the actual Doi has expiered, the field must be filled with the expected value
6- if the there is an existing value or the TTL is not yet reached, it won't perform fetching and will keep the same value
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)