Skip to content

Disallow multiple consecutive blank lines in CHANGELOG.md#12736

Merged
koppor merged 2 commits into
mainfrom
koppor-patch-1
Mar 13, 2025
Merged

Disallow multiple consecutive blank lines in CHANGELOG.md#12736
koppor merged 2 commits into
mainfrom
koppor-patch-1

Conversation

@koppor

@koppor koppor commented Mar 13, 2025

Copy link
Copy Markdown
Member

Triggered by https://github.com/JabRef/jabref/pull/12718/files

This enables https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md012---multiple-consecutive-blank-lines

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@trag-bot

trag-bot Bot commented Mar 13, 2025

Copy link
Copy Markdown

@trag-bot didn't find any issues in the code! ✅✨

@Siedlerchr

Copy link
Copy Markdown
Member

Multiple blank lines - at least two are easier than it will not be producing merge conflicts,

@koppor

koppor commented Mar 13, 2025

Copy link
Copy Markdown
Member Author

Multiple blank lines - at least two are easier than it will not be producing merge conflicts,

We did not have any in our current CHANGELOG.md

And we have merge=union:

CHANGELOG.md merge=union

@koppor

koppor commented Mar 13, 2025

Copy link
Copy Markdown
Member Author

See the diff what I needed two remove - only one in unreleased and one in a released versoin: https://github.com/JabRef/jabref/pull/12736/files

@Siedlerchr

Copy link
Copy Markdown
Member

ok

@koppor koppor merged commit e6b3a76 into main Mar 13, 2025
@koppor koppor deleted the koppor-patch-1 branch March 13, 2025 18:16
@github-actions

Copy link
Copy Markdown
Contributor

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@koppor koppor mentioned this pull request Mar 13, 2025
7 tasks
GuilhermeRibeiroPereira pushed a commit to GuilhermeRibeiroPereira/jabref that referenced this pull request Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants