Skip to content

Change tooltip delay #12718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
koppor merged 11 commits into from
Mar 13, 2025
Merged

Change tooltip delay #12718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
08603ec
Fixed tooltip delay (#12649)
Imran8125 Mar 12, 2025
b47c816
corrected a typo in CHANGELOD.md
Imran8125 Mar 12, 2025
84a205c
Updated the CHANGELOG
Imran8125 Mar 13, 2025
7bd0b40
Merge branch 'main' into fix-tooltip-delay
Imran8125 Mar 13, 2025
7cd4e33
Removed the setShowDelay method
Imran8125 Mar 13, 2025
2ab50ce
Merge branch 'fix-tooltip-delay' of https://github.com/Imran8125/jabr…
Imran8125 Mar 13, 2025
6349f32
Merge branch 'main' into fix-tooltip-delay
Imran8125 Mar 13, 2025
17a1900
fixed the checkstyle
Imran8125 Mar 13, 2025
22e0b34
Merge branch 'fix-tooltip-delay' of https://github.com/Imran8125/jabr…
Imran8125 Mar 13, 2025
a489b3f
Merge branch 'main' into fix-tooltip-delay
koppor Mar 13, 2025
2a6f1c4
Apply suggestions from code review
koppor Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv
- We improved the Check Integrity dialog entry interaction so that a single click focuses on the corresponding entry and a double-click both focuses on the entry and closes the dialog. [#12245](https://github.com/JabRef/jabref/issues/12245)
- We improved journal abbreviation lookup with fuzzy matching to handle minor input errors and variations. [#12467](https://github.com/JabRef/jabref/issues/12467)
- We changed the phrase "Cleanup entries" to "Clean up entries". [#12703](https://github.com/JabRef/jabref/issues/12703)
- A tooltip now appears after 300ms (instead of 2s). [#12649](https://github.com/JabRef/jabref/issues/12649)

Comment thread
Imran8125 marked this conversation as resolved.
### Fixed

Expand Down
2 changes: 2 additions & 0 deletions src/main/java/org/jabref/gui/Base.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,8 @@ TextFlow > .hyperlink:visited,
-fx-opacity: 95%;
-fx-text-fill: -jr-tooltip-fg;
-fx-font-size: 1em;
-fx-show-delay: 300ms;
-fx-hide-delay: 300ms;
}

.tooltip > TextFlow > Text {
Expand Down
2 changes: 0 additions & 2 deletions src/main/java/org/jabref/gui/maintable/MainTableTooltip.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
import javafx.scene.control.Label;
import javafx.scene.control.Tooltip;
import javafx.scene.layout.VBox;
import javafx.util.Duration;

import org.jabref.gui.DialogService;
import org.jabref.gui.preferences.GuiPreferences;
Expand All @@ -23,7 +22,6 @@ public class MainTableTooltip extends Tooltip {
public MainTableTooltip(DialogService dialogService, GuiPreferences preferences, ThemeManager themeManager, TaskExecutor taskExecutor) {
this.preferences = preferences;
this.preview = new PreviewViewer(dialogService, preferences, themeManager, taskExecutor);
this.setShowDelay(Duration.seconds(1));
this.tooltipContent.getChildren().addAll(fieldValueLabel, preview);
}

Expand Down