Skip to content

Change tooltip delay#12718

Merged
koppor merged 11 commits into
JabRef:mainfrom
Imran8125:fix-tooltip-delay
Mar 13, 2025
Merged

Change tooltip delay#12718
koppor merged 11 commits into
JabRef:mainfrom
Imran8125:fix-tooltip-delay

Conversation

@Imran8125

@Imran8125 Imran8125 commented Mar 12, 2025 •
edited by subhramit
Loading

Copy link
Copy Markdown
Contributor

Description
This PR fixes tooltip delay from 2sec to 500ms and made changes to Base.css and MainTableTooltip

Changes
Updated Base.css to adjust tooltip delay settings.
Modified MainTableTooltip to align with these changes.
Why?
Ensures a smoother UX experience.
Closes #12649

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Screenshot (5801)

trag-bot[bot]
trag-bot Bot reviewed Mar 12, 2025
View reviewed changes
Comment thread src/main/java/org/jabref/gui/maintable/MainTableTooltip.java Outdated
subhramit
subhramit reviewed Mar 12, 2025
View reviewed changes
Comment thread src/main/java/org/jabref/gui/maintable/MainTableTooltip.java Outdated
subhramit
subhramit reviewed Mar 12, 2025
View reviewed changes
Comment thread CHANGELOG.md
subhramit
subhramit reviewed Mar 12, 2025
View reviewed changes
Comment thread CHANGELOG.md Outdated
@subhramit subhramit changed the title Fix tooltip delay Change tooltip delay Mar 12, 2025
@Imran8125

Imran8125 commented Mar 13, 2025

Copy link
Copy Markdown
Contributor Author

1)I have updated the tooltip delay in Base.css, ensuring uniformity across all places.
2)I checked the tooltip delay in MS Word and other common software, and they also use 500ms. I have applied the same value in Base.css to ensure consistency.
3)I updated the CHANGELOG as per your suggestion
Let me know if any further adjustments are needed

@subhramit

subhramit commented Mar 13, 2025

Copy link
Copy Markdown
Member

1)I have updated the tooltip delay in Base.css, ensuring uniformity across all places.

If that is the case, why was a separate change needed at the maintable class?

@Imran8125

Imran8125 commented Mar 13, 2025

Copy link
Copy Markdown
Contributor Author

1)I have updated the tooltip delay in Base.css, ensuring uniformity across all places.

If that is the case, why was a separate change needed at the maintable class?

The Base.css change ensures uniform delay, but MainTable had a separate setting that needed adjustment for consistency

subhramit
subhramit reviewed Mar 13, 2025
View reviewed changes
Comment thread src/main/java/org/jabref/gui/maintable/MainTableTooltip.java Outdated
this.preferences = preferences;
this.preview = new PreviewViewer(dialogService, preferences, themeManager, taskExecutor);
this.setShowDelay(Duration.seconds(1));
this.setShowDelay(Duration.millis(500));

@subhramit subhramit Mar 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be removed then? @Siedlerchr
With reference to #12718 (comment)

@Siedlerchr Siedlerchr Mar 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes make it consistent

@koppor koppor Mar 13, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is still in the code. WHY?

@subhramit subhramit Mar 13, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Imran8125 please do not resolve review comments until you have acted on them

@Imran8125 Imran8125 Mar 13, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@koppor I have now removed it to ensure consistency. Let me know if any further changes are needed.

@koppor

koppor commented Mar 13, 2025

Copy link
Copy Markdown
Member

Your pull request conflicts with the target branch. Please merge upstream/main with your code. Preferrably, do this using git in your machine. Conflicts in CHANGELOG.md will be handled by a union of changes.

@Imran8125 Please do not ignore that comment. If the text is unclear, please propose a new text.

GitHub also shows a button to take action:

image

koppor
koppor requested changes Mar 13, 2025
View reviewed changes
Comment thread src/main/java/org/jabref/gui/maintable/MainTableTooltip.java Outdated
this.preferences = preferences;
this.preview = new PreviewViewer(dialogService, preferences, themeManager, taskExecutor);
this.setShowDelay(Duration.seconds(1));
this.setShowDelay(Duration.millis(500));

@koppor koppor Mar 13, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is still in the code. WHY?

koppor
koppor approved these changes Mar 13, 2025
View reviewed changes
Comment thread CHANGELOG.md Outdated
Comment thread src/main/java/org/jabref/gui/Base.css Outdated
Comment thread src/main/java/org/jabref/gui/Base.css Outdated
Comment thread src/main/java/org/jabref/gui/Base.css Outdated
Comment thread CHANGELOG.md Outdated
koppor
koppor requested changes Mar 13, 2025
View reviewed changes

@koppor koppor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

500ms is still to slow for me as impatient user.

That the tooltip suddenly disappears (without fade-out) puzzles me. Therefore the proposal to remove it.

@koppor

koppor commented Mar 13, 2025

Copy link
Copy Markdown
Member

I updated the branch to bring in #12736 here, too.

@koppor koppor enabled auto-merge March 13, 2025 18:28
@trag-bot

trag-bot Bot commented Mar 13, 2025

Copy link
Copy Markdown

@trag-bot didn't find any issues in the code! ✅✨

@koppor koppor added this pull request to the merge queue Mar 13, 2025
Merged via the queue into JabRef:main with commit 8fc9800 Mar 13, 2025
GuilhermeRibeiroPereira pushed a commit to GuilhermeRibeiroPereira/jabref that referenced this pull request Apr 1, 2025
@Imran8125 @koppor @GuilhermeRibeiroPereira
Change tooltip delay (JabRef#12718)
3e0dff6 
* Fixed tooltip delay  (JabRef#12649)

* corrected a typo in CHANGELOD.md

* Updated the CHANGELOG

* Removed the setShowDelay method

* fixed the checkstyle

* Apply suggestions from code review

---------

Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Siedlerchr Siedlerchr Siedlerchr left review comments

@subhramit subhramit subhramit left review comments

@trag-bot trag-bot[bot] trag-bot[bot] left review comments

@koppor koppor koppor approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Reduce tooltip delay from 2s to 500ms/1s for improved UX

4 participants

@Imran8125 @subhramit @koppor @Siedlerchr