Skip to content

Fix BSTVM#11304

Merged
Siedlerchr merged 14 commits into
mainfrom
fix-bst-vm
May 20, 2024
Merged

Fix BSTVM#11304
Siedlerchr merged 14 commits into
mainfrom
fix-bst-vm

Conversation

@koppor

@koppor koppor commented May 19, 2024

Copy link
Copy Markdown
Member

Seperate PR to focus on the VM and not to "pollute" the student PR. (And I had write issues to the branch there)

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Comment thread src/main/java/org/jabref/logic/util/TestEntry.java Outdated
Comment thread src/main/java/org/jabref/logic/util/TestEntry.java Outdated
Comment thread src/main/java/org/jabref/logic/util/TestEntry.java Outdated
Comment thread src/main/java/org/jabref/logic/util/TestEntry.java Outdated
Comment thread src/main/java/org/jabref/logic/util/TestEntry.java Outdated
Comment thread src/main/java/org/jabref/logic/util/TestEntry.java Outdated
Comment thread src/main/java/org/jabref/logic/util/TestEntry.java Outdated
Comment thread src/main/java/org/jabref/logic/util/TestEntry.java Outdated
Comment thread src/main/java/org/jabref/logic/bst/BstVMVisitor.java Outdated
Comment thread src/main/java/org/jabref/logic/bst/BstVMVisitor.java Outdated
Comment thread src/main/java/org/jabref/logic/bst/BstVMVisitor.java Outdated
@koppor koppor marked this pull request as ready for review May 20, 2024 07:09
@github-actions

github-actions Bot commented May 20, 2024

Copy link
Copy Markdown
Contributor

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@Siedlerchr Siedlerchr added this pull request to the merge queue May 20, 2024
Merged via the queue into main with commit c4c0a23 May 20, 2024
@Siedlerchr Siedlerchr deleted the fix-bst-vm branch May 20, 2024 09:11
Siedlerchr added a commit to sahilsekr42/jabref that referenced this pull request May 20, 2024
* upstream/main:
  Fix BSTVM (JabRef#11304)

# Conflicts:
#	src/main/java/org/jabref/logic/bst/BstVM.java
#	src/main/java/org/jabref/logic/bst/BstVMVisitor.java
#	src/test/java/org/jabref/logic/bst/BstVMTest.java
@calixtus

Copy link
Copy Markdown
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants