No need to close the PR and reopen. Just continue committing and pushing. The PR will be updated automatically

think for preview to function well bstvm should be used not sure how

I am not quite sure I understand you correctly, but the BstPreviewLayout itself already handles the bstVm:, so it should work out of the box

@Siedlerchr thanks I didn't really understand the mechanism of updating pull request (i.e. just committing to my branch automatically updates the pr and runs tests again.

Thanks for the PR! We refactored the code a bit and found an issue with the BST rendering itself, (not your fault, but we would like to continue here, so please leave the PR open).

Intermediate result:

• Running IEEEtran.bst with this branch leads to a failure
• Running IEEEtran.bst with ANTLR4, works (see Add testIeee to ANTLRv3-based BST VM jabref-koppor#685)
• Thus, I assume that Update BST VM to Antlr4 #8934 broke our VM.

Tested some other styles that work:

https://raw.githubusercontent.com/CarlOrff/apalike-german/master/apalike-german.bst
https://ctan.org/pkg/alphanumb
https://github.com/wacv-pcs/WACV-2023-Author-Kit/blob/main/ieee.bst
https://www.ctan.org/tex-archive/biblio/bibtex/base/acm.bst
Apalike: https://www.ctan.org/tex-archive/biblio/bibtex/base

interestingly, the IEEEtr.bst from the base style sworks as well
https://mirrors.ctan.org/biblio/bibtex/base/ieeetr.bst

Current state:

The t is a function which is "not found", but t seems to be string or a variable.

Maybe, the whole new interpretation mixes up parsing of the .bst file and the real execution.

Other than that, I find following code strange - this seems to mix parsing and execution

    @Override
    public Integer visitBstFunction(BstParser.BstFunctionContext ctx) {
        String name = ctx.getChild(0).getText();
        if (bstVMContext.functions().containsKey(name)) {
            LOGGER.trace("Function '{}' found", name);
            bstVMContext.functions().get(name).execute(this, ctx, selectedBstEntry);
        } else {
            LOGGER.trace("Function '{}' not found", name);
            visit(ctx.getChild(0));
        }

        return BstVM.TRUE;
    }

Strange git error:

error: Authentication error: Authentication required: You must have push access to verify locks
error: failed to push some refs to 'https://github.com/sahilsekr42/jabref.git'

Pushed to koppor.

something with git lfs stuff

We identified that there is an endless loop happening in following bst function

% Converts all single dashes "-" to double dashes "--".
FUNCTION {n.dashify}
{ large.number.separate
  't :=
  ""
    { t empty$ not }
    { t #1 #1 substring$ "-" =
        { t #1 #2 substring$ "--" = not
            { "--" *
              t #2 global.max$ substring$ 't :=
            }
            {   { t #1 #1 substring$ "-" = }
                { "-" *
                  t #2 global.max$ substring$ 't :=
                }
              while$
            }
          if$
        }
        { t #1 #1 substring$ *
          t #2 global.max$ substring$ 't :=
        }
      if$
    }
  while$
}

(And we fixed the lookup)

Storing in the prefs now works as well