Skip to content

Add testIeee to ANTLRv3-based BST VM#685

Closed
koppor wants to merge 1 commit into
mainfrom
demonstrate-hang
Closed

Add testIeee to ANTLRv3-based BST VM#685
koppor wants to merge 1 commit into
mainfrom
demonstrate-hang

Conversation

@koppor

@koppor koppor commented Apr 25, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

This adds the ieee test from https://github.com/JabRef/jabref/pull/11234/files#diff-b5c55d3aa722352a825d998f1e417b12684dde5386937e4f69b0f47202a1b7cb to the commit before the migration to ANTLR4 (02f51f7)

Let's see if it hangs.

Result: It does not hang.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor mentioned this pull request Apr 25, 2024
Merged
6 tasks
@koppor koppor changed the title Add testIeee Add testIeee to ANTLRv3-based BST VM May 19, 2024
@koppor

koppor commented May 19, 2024

Copy link
Copy Markdown
Member Author

Test result:

org.opentest4j.AssertionFailedError: expected:

<begin{thebibliography}{1}bibitem{canh05}K.~Crowston,H.~Annabi,J.~Howison,andC.~Masango.newblockEffectiveworkpracticesforflossdevelopment:Amodelandpropositions.newblockIn{emHawaiiInternationalConferenceOnSystemSciences(HICSS)},2005.end{thebibliography}>

but was: 

<%GeneratedbyIEEEtran.bst,version:1.14(2015/08/26)begin{thebibliography}{1}providecommand{url}[1]{#1}csnameurl@samestyleendcsnameprovidecommand{newblock}{relax}providecommand{bibinfo}[2]{#2}providecommand{BIBentrySTDinterwordspacing}{spaceskip=0ptrelax}providecommand{BIBentryALTinterwordstretchfactor}{4}providecommand{BIBentryALTinterwordspacing}{spaceskip=fontdimen2fontplusBIBentryALTinterwordstretchfactorfontdimen3fontminusfontdimen4fontrelax}providecommand{BIBforeignlanguage}[2]{{%expandafterifxcsnamel@#1endcsnamerelaxtypeout{**WARNING:IEEEtran.bst:Nohyphenationpatternhasbeen}%typeout{**loadedforthelanguage`#1'.Usingthepatternfor}%typeout{**thedefaultlanguageinstead.}%elselanguage=csnamel@#1endcsnamefi#2}}providecommand{BIBdecl}{relax}BIBdeclbibitem{canh05}BIBentryALTinterwordspacingK.~Crowston,H.~Annabi,J.~Howison,andC.~Masango,``Effectiveworkpracticesforflossdevelopment:Amodelandpropositions''inemph{HawaiiInternationalConferenceOnSystemSciences(HICSS)},2005.[Online].Available:url{[http://james.howison.name/publications.html}BIBentrySTDinterwordspacingend{thebibliography](http://james.howison.name/publications.htmlBIBentrySTDinterwordspacingend%7Bthebibliography%7D)}>

@koppor

koppor commented May 21, 2024

Copy link
Copy Markdown
Member Author

We fixed it in JabRef#11304

@koppor koppor closed this May 21, 2024
@koppor koppor deleted the demonstrate-hang branch May 21, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@koppor