Clean up test code#10658
Merged
Merged
Conversation
Siedlerchr
approved these changes
Nov 21, 2023
Siedlerchr
added a commit
to xuanan20020/jabref
that referenced
this pull request
Nov 21, 2023
* upstream/main: (24 commits) Clean up test code (JabRef#10658) Bump org.openrewrite.rewrite from 6.4.0 to 6.5.4 (JabRef#10650) Bump com.puppycrawl.tools:checkstyle from 10.12.4 to 10.12.5 (JabRef#10654) Bump com.fasterxml.jackson.dataformat:jackson-dataformat-yaml (JabRef#10653) Bump com.github.Dansoftowner:jSystemThemeDetector from 3.6 to 3.8 Remove comments - don't work on forks Update journal abbreviation lists (JabRef#10645) Use clparse (instead of heylogs) (JabRef#10641) Update CSL styles (JabRef#10642) Added parent field to Hayagriva YAML export (JabRef#10633) Bump org.fxmisc.richtext:richtextfx from 0.11.1 to 0.11.2 (JabRef#10637) Bump io.github.classgraph:classgraph from 4.8.163 to 4.8.164 (JabRef#10634) Bump org.junit.platform:junit-platform-launcher from 1.10.0 to 1.10.1 (JabRef#10635) Bump org.mockito:mockito-core from 5.6.0 to 5.7.0 (JabRef#10638) Bump com.tngtech.archunit:archunit-junit5-engine from 1.1.0 to 1.2.0 (JabRef#10636) add some more spaces Fix CHANGELOG.md Remove SearchListener Refactor method name to reflect usage Revert "Remove filtering on query in maintable" ...
Siedlerchr
added a commit
that referenced
this pull request
Nov 26, 2023
* upstream/main: App semantic scholar api key to properties (#10656) Replace cache: gradle with "odern" gradle-build-action (#10657) Clean up test code (#10658) Bump org.openrewrite.rewrite from 6.4.0 to 6.5.4 (#10650) Bump com.puppycrawl.tools:checkstyle from 10.12.4 to 10.12.5 (#10654) Bump com.fasterxml.jackson.dataformat:jackson-dataformat-yaml (#10653) Bump com.github.Dansoftowner:jSystemThemeDetector from 3.6 to 3.8 Remove comments - don't work on forks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables rewrite of tests using OpenRewrite's JUni5 "cleanup assertions" recipe: https://docs.openrewrite.org/recipes/java/testing/junit5/cleanupassertions
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)