Skip to content

App semantic scholar api key to properties#10656

Merged
Siedlerchr merged 9 commits into
mainfrom
appSemanticScholarApiKeyToProperties
Nov 22, 2023
Merged

App semantic scholar api key to properties#10656
Siedlerchr merged 9 commits into
mainfrom
appSemanticScholarApiKeyToProperties

Conversation

@Siedlerchr

Copy link
Copy Markdown
Member

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

koppor and others added 3 commits November 20, 2023 21:20
…rs' into appSemanticScholarApiKeyToProperties

* upstream/add-semantic-scholar-to-fetchers:
  Update fetchers.md
Comment thread src/main/java/org/jabref/logic/util/BuildInfo.java Outdated
@Siedlerchr Siedlerchr enabled auto-merge November 20, 2023 21:54
Comment thread src/main/java/org/jabref/logic/util/BuildInfo.java
@github-actions

github-actions Bot commented Nov 21, 2023

Copy link
Copy Markdown
Contributor

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@Siedlerchr Siedlerchr added this pull request to the merge queue Nov 22, 2023
Merged via the queue into main with commit 43364b8 Nov 22, 2023
@Siedlerchr Siedlerchr deleted the appSemanticScholarApiKeyToProperties branch November 22, 2023 12:59
yuyan-z pushed a commit to yuyan-z/jabref that referenced this pull request Nov 25, 2023
* Update fetchers.md

* Add API key handling for semantic scholar

* checkstyle

* add env var

* fix template expansion

* Fix some fetcher tests

* checkstyle

* revert deletion

---------

Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
Siedlerchr added a commit that referenced this pull request Nov 26, 2023
* upstream/main:
  App semantic scholar api key to properties (#10656)
  Replace cache: gradle with "odern" gradle-build-action (#10657)
  Clean up test code (#10658)
  Bump org.openrewrite.rewrite from 6.4.0 to 6.5.4 (#10650)
  Bump com.puppycrawl.tools:checkstyle from 10.12.4 to 10.12.5 (#10654)
  Bump com.fasterxml.jackson.dataformat:jackson-dataformat-yaml (#10653)
  Bump com.github.Dansoftowner:jSystemThemeDetector from 3.6 to 3.8
  Remove comments - don't work on forks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants