Add FILTER TCP API for remote bandpass filter control#209
Merged
Conversation
- WideGraph.h/.cpp : getters filterCenter() et filterWidth() - networkMessage.cpp : FILTER.GET_FILTER, FILTER.SET_FILTER, FILTER.SET_ENABLED - Permet le controle du filtre visuel waterfall via TCP (QMX-Pi Session 87) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
wmiler
reviewed
Mar 2, 2026
wmiler
left a comment
Collaborator
There was a problem hiding this comment.
Any reason this isn't in the RX category? Are you sure you want to start another category?
Contributor
Author
|
Let me put that in RX |
- Rename FILTER.GET_FILTER -> RX.GET_FILTER - Rename FILTER.SET_FILTER -> RX.SET_FILTER - Rename FILTER.SET_ENABLED -> RX.SET_FILTER_ENABLED - Response type FILTER.FILTER -> RX.FILTER - Add @note API 2.6+ to each @brief block - Remove standalone FILTER command group (now part of RX) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
BrunoKlu
added a commit
to BrunoKlu/JS8Call-improved
that referenced
this pull request
Mar 2, 2026
Applique les memes corrections que PRs JS8Call-improved#207/JS8Call-improved#208/JS8Call-improved#209 sur la branche qmx-pi : MODE.* → STATION.* pour les commandes config, FILTER.* → RX.* pour les commandes filtre, @note API 2.6+ sur tous les @brief, et traduction commentaires francais → anglais. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
wmiler
reviewed
Mar 3, 2026
Closed
Move RX.GET_FILTER, RX.SET_FILTER and RX.SET_FILTER_ENABLED handlers from after the MODE section into the RX section, just before the End RX Commands marker. Update summary comment block. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
wmiler
approved these changes
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filterCenter()andfilterWidth()public getters toWideGraphFILTER.GET_FILTER— returns current center, width, and enabled stateFILTER.SET_FILTER— set CENTER and/or WIDTH parametersFILTER.SET_ENABLED— toggle filter overlay on/offMotivation
JS8Call-improved already exposes most station/RX/TX/MODE settings via TCP, but the bandpass filter has no TCP API. This makes it impossible for headless or remote setups to control the filter overlay.
The filter remains purely visual (no DSP) — these commands control the same overlay that the desktop Qt spinbox/dial widgets control.
Changes
JS8_UI/WideGraph.hfilterCenter() const,filterWidth() constJS8_UI/WideGraph.cppm_filterCenter,m_filterWidth)JS8_Mainwindow/networkMessage.cppAPI Details
FILTER.GET_FILTER
Returns:
FILTER.FILTERwith{CENTER: int, WIDTH: int, ENABLED: bool}FILTER.SET_FILTER
Params:
{CENTER: int}and/or{WIDTH: int}Returns:
FILTER.FILTERwith updated stateFILTER.SET_ENABLED
Value:
"true"or"false"Returns:
FILTER.SET_ENABLEDwith{ENABLED: bool}Test plan
FILTER.GET_FILTERvia TCP — verify JSON response with CENTER, WIDTH, ENABLEDFILTER.SET_FILTERwith CENTER/WIDTH params — verify filter moves on waterfallFILTER.SET_ENABLED— verify filter toggles on/off