TCP API: STATION.SET_GROUPS + STATION.SET_AVOID_ALLCALL#208
Merged
Conversation
- networkMessage.cpp: MODE.GET_CONFIG, SET_AUTO_REPLY, SET_JS8HB, SET_HBACK, SET_MULTI_DECODER, SET_HB_INTERVAL, SET_HB_TIMER, SEND_HB - mainwindow.cpp/h: confirmThenEnqueueMessage() sends TCP push instead of SelfDestructMessageBox (headless/xvfb compatible) - Configuration.cpp/h: autoreply_confirmation accessor Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…s live - MODE.SET_GROUPS : remplacement direct de la liste via setMyGroups() (bypass addGroup MessageBox bloquant sous xvfb) - MODE.SET_AVOID_ALLCALL : toggle opt-out @allcall via TCP - MODE.GET_CONFIG enrichi : retourne MY_GROUPS + AVOID_ALLCALL - setMyGroups(QStringList) dans Configuration : ecriture directe + write_settings() Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Verifie isGroupAllowed() + isCompoundCallsign() pour chaque groupe - Retourne une erreur TCP (champ ERROR) au lieu d'ouvrir un MessageBox Qt - Compatible headless (xvfb) et clients TCP generiques Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
|
This all needs to move to STATION as well. MODE is reserved for the |
BrunoKlu
added a commit
to BrunoKlu/JS8Call-improved
that referenced
this pull request
Mar 2, 2026
Applique les memes corrections que PRs JS8Call-improved#207/JS8Call-improved#208/JS8Call-improved#209 sur la branche qmx-pi : MODE.* → STATION.* pour les commandes config, FILTER.* → RX.* pour les commandes filtre, @note API 2.6+ sur tous les @brief, et traduction commentaires francais → anglais. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Closed
Move all STATION.* command handlers (GET_CONFIG, SET_AUTO_REPLY, SET_JS8HB, SET_HBACK, SET_MULTI_DECODER, SET_HB_INTERVAL, SET_HB_TIMER, SEND_HB, SET_AUTOREPLY_CONFIRMATION, AUTOREPLY_CONFIRM_RESPONSE, SET_GROUPS, SET_AVOID_ALLCALL) from the MODE section to the STATION section, just before the End STATION Commands marker. Fix End MODE Commands marker. Update summary comment block with new command list. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Collaborator
|
The code here looks good. I think there's three outstanding API-based PR's that will have to be merged in order and conflicts resolved by rebasing on master as we go. |
Collaborator
Yeah, I think he had 2 PRs from the same branch, I'm at a mini FD right now, and not in front of my dev machine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds TCP commands to manage JS8Call groups and @allcall opt-out remotely, enabling headless operation without the Qt Settings dialog.
Depends on PR #207 (TCP API: 8 MODE commands + headless autoreply confirmation)
New TCP commands
MODE.SET_GROUPSMODE.SET_AVOID_ALLCALLMODE.GET_CONFIGMY_GROUPSandAVOID_ALLCALLfieldsValidation
MODE.SET_GROUPSvalidates each group usingVaricode::isGroupAllowed()andVaricode::isCompoundCallsign(), returning a TCP error response instead of opening aJS8MessageBox(which blocks under xvfb/headless).Example error response:
{"type": "MODE.SET_GROUPS", "params": {"ERROR": "Group not allowed: @APRSIS"}}Configuration::setMyGroups()Bulk-replaces the groups list without per-group
addGroup()calls, which useJS8MessageBox::critical_message()on invalid input — blocking under xvfb.setMyGroups()writes directly viawrite_settings().Changes
JS8_Mainwindow/networkMessage.cppJS8_UI/Configuration.cppsetMyGroups()method (+5 lines)JS8_UI/Configuration.h63 insertions, 0 deletions across 3 files.
Testing
MyGroupskey) afterMODE.SET_GROUPSAvoidAllcallINI keyMODE.GET_CONFIGreturns correctMY_GROUPSandAVOID_ALLCALLvalues