Fix TCP API RX.DIRECTED to match DIRECTED.txt output#176
Merged
Chris-AC9KH merged 4 commits intoFeb 1, 2026
Conversation
The value field in RX.DIRECTED messages was using the formatted 'text' variable which includes the FROM callsign prefix. When TCP clients reconstruct messages as "FROM: value", this resulted in duplicate callsigns (e.g., "W9TEK: W9TEK: KC1QKM SNR -05"). Changed the value parameter from 'text' to 'd.text' (the raw message body without FROM prefix) to match the TEXT parameter behavior. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
FROM prefix The previous fix incorrectly used d.text which is empty for simple directed messages. This fix properly constructs valueWithoutFrom from the message components (d.to, d.cmd, d.extra, d.text).
Both value and TEXT fields now contain the message body without the FROM prefix, making the API consistent and useful for clients. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
wmiler
previously approved these changes
Jan 30, 2026
Didn't read this quite as well as I meant to.
Collaborator
|
Why do you want the EOT character in the API feed? |
Collaborator
Author
|
As you know, I’ve been working to fix an issue with duplicate callsigns in the API feed. My first attempt didn’t resolve the problem (#123). The second attempt did eliminate the duplicate callsigns by introducing a second variable, but it also removed the EOT character, which had always been present in the API output.
After reviewing the logic again, I realized the second variable wasn’t necessary. I refactored the code back to a single variable, which restores the EOT character while still addressing the original issue. I haven’t tested this version yet, but I’m confident it should work. I’ll verify it tonight when I get home.
…On Friday, January 30th, 2026 at 4:35 PM, Wyatt Miler ***@***.***> wrote:
wmiler left a comment [(JS8Call-improved/JS8Call-improved#176)](#176 (comment))
Why do you want the EOT character in the API feed?
—
Reply to this email directly, [view it on GitHub](#176 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/ACDJQ7GJVDLZ6BOEVQ3WC7L4JPFALAVCNFSM6AAAAACTK6VY7KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTQMRVHA3DSOBQHE).
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Collaborator
Ah, ok, gotcha. |
Collaborator
Author
|
I tested the changes I made for duplicate callsigns and everything is working as expected.
…On Friday, January 30th, 2026 at 5:24 PM, Wyatt Miler ***@***.***> wrote:
wmiler left a comment [(JS8Call-improved/JS8Call-improved#176)](#176 (comment))
> As you know, I’ve been working to fix an issue with duplicate callsigns in the API feed. My first attempt didn’t resolve the problem ([#123](#123)). The second attempt did eliminate the duplicate callsigns by introducing a second variable, but it also removed the EOT character, which had always been present in the API output. After reviewing the logic again, I realized the second variable wasn’t necessary. I refactored the code back to a single variable, which restores the EOT character while still addressing the original issue. I haven’t tested this version yet, but I’m confident it should work. I’ll verify it tonight when I get home.
Ah, ok, gotcha.
—
Reply to this email directly, [view it on GitHub](#176 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/ACDJQ7H6SRSXNEXUSDFBYXT4JPK2TAVCNFSM6AAAAACTK6VY7KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTQMRWGA3TQOJXGA).
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
wmiler
approved these changes
Jan 31, 2026
Collaborator
|
Merged. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
baseTextvariable with clear comments explaining the data flowProblem
When JS8Call sends directed messages via TCP API, there were two issues:
Solution
Refactored to use a single
baseTextvariable:baseTextcontains"TO CMD EXTRA TEXT [eot]"(used for TCP API where FROM is a separate JSON field)textcontains"FROM: TO CMD EXTRA TEXT [eot]"(used for DIRECTED.txt file and UI display)This ensures the eot character is applied once and consistently appears in both outputs, while keeping FROM out of the VALUE/TEXT fields.
Test plan
FROM: TO CMD EXTRA TEXT ♢TO CMD EXTRA TEXT ♢(no FROM prefix, includes eot)🤖 Generated with Claude Code