Fix duplicate callsign in RX.DIRECTED TCP messages#123
Merged
wmiler merged 1 commit intoJan 8, 2026
Conversation
TEXT param contained the full formatted message including FROM prefix, causing duplication when clients reconstruct the message. Changed to use d.text (message body) instead.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed bug where the callsign was duplicated in TCP output for RX.DIRECTED messages.
The Problem
The TEXT param in the RX.DIRECTED JSON message contained the full formatted string (which already includes the FROM callsign). When TCP clients reconstruct the display using FROM + ": " + TEXT, the callsign appears twice.
DIRECTED.txt (correct):
2025-12-06 16:07:27 14.078000 2025 -03 K9BTR: N0ASH HEARTBEAT SNR -19 ♢
2025-12-06 16:07:27 14.078000 2025 +06 WA3YWU: N0ASH HEARTBEAT SNR -06 ♢
TCP output (buggy):
2025-12-06 16:07:27 14.078000 2025 -03 K9BTR: K9BTR: N0ASH HEARTBEAT SNR -19 ♢
2025-12-06 16:07:27 14.078000 2025 +06 WA3YWU: WA3YWU: N0ASH HEARTBEAT SNR -06 ♢
The Fix
Changed TEXT param from "text" (full formatted message) to "d.text" (message body only).