Toggle notifications only, keep vibrations. #664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Collaborator
|
Looks good to me, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the button with a bell icon disable notifications instead of disabling vibrations. This makes Timer and Metronome work correctly when notifications are disabled. When disabled, the watch won't wake up when receiving notifications and will show an icon on the watch face indicating a new notification. This was always present, but wasn't ever shown.
Fixes #637
Related to #610, because now the notification screen won't pop up when notifications have been disabled.
Inspred by #662 so that we wouldn't need a
StartRingingDisregardSettings()function.