Correctly map Brigadier suggestions to cloud#595
Merged
Citymonstret merged 1 commit intofeat/2.0.0/commandinput-suggestionsfrom Dec 27, 2023
Merged
Conversation
cloud expects the suggestion to be a replacement for the entire argument, use Brigadier's range information to meet that requirement.
d3689b4 to
1986517
Compare
Citymonstret
approved these changes
Dec 27, 2023
This was referenced Dec 28, 2023
jpenilla
added a commit
that referenced
this pull request
Dec 30, 2023
* feat(core): don't use requested argument count for suggestions Instead of relying on the parser to tell us how many arguments it wants, we just check if it's able to consume all the input. * feat: make suggestion providers accept CommandInput * feat: allow `@Suggestions` to accept `CommandInput` * chore: update `SuggestionProvider` JavaDoc * feat: add test for a multi-token-consuming parser * Correctly map Brigadier suggestions to cloud (#595) cloud expects the suggestion to be a replacement for the entire argument, use Brigadier's range information to meet that requirement. * feat: preserve whitespace when reading from CommandInput (#599) * fix: don't preemptively switch component for aggregate suggestions * Remove BlockingSuggestionProvider.ConstantStrings (#605) * Remove ArgumentParser#getRequestedArgumentCount (#607) * remove unnecessary future chaining this is not needed after the extraction of aggregate suggestion logic --------- Co-authored-by: Jason Penilla <11360596+jpenilla@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cloud expects the suggestion to be a replacement for the entire argument, use Brigadier's range information to meet that requirement.