feat: make suggestion providers accept CommandInput#594
Merged
Conversation
Instead of relying on the parser to tell us how many arguments it wants, we just check if it's able to consume all the input.
58f7262 to
0aafdfa
Compare
0aafdfa to
fe5fb25
Compare
cloud expects the suggestion to be a replacement for the entire argument, use Brigadier's range information to meet that requirement.
this is not needed after the extraction of aggregate suggestion logic
jpenilla
approved these changes
Dec 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also fixes a ton of issues with suggestions for arguments that consume multiple strings.
includes #595, #599, #607
Todo:
MethodSuggestionProviderrequirements to allow forCommandInputparametersSuggestionProvider,Suggestions)