fix: Address regressions introduced by recent new features & refactoring#334
fix: Address regressions introduced by recent new features & refactoring#334igoroctaviano merged 10 commits intomasterfrom
Conversation
|
Here's the code health analysis summary for commits Analysis Summary
|
There was a problem hiding this comment.
Pull Request Overview
This PR addresses regressions introduced by recent new features by implementing a configurable logger system, updating segmentation handling, and fixing various console calls throughout the codebase.
- Adds a comprehensive logger utility with configurable log levels and environment-specific settings
- Removes the
generateSegmentColorfunction and updatesgetSegmentColorto return null when no metadata color is found - Replaces console calls with the new logger system and handles fractional vs binary segmentation types differently
Reviewed Changes
Copilot reviewed 11 out of 16 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/segmentColors.ts | Removes color generation function, updates getSegmentColor signature, adds getSegmentationType function |
| src/utils/logger.ts | New configurable logger utility with environment-aware logging levels |
| src/utils/logger.test.ts | Unit tests for the logger functionality |
| src/utils/tests/segmentColors.test.ts | Adds tests for the new getSegmentationType function |
| src/components/SlideViewer/utils/roiUtils.ts | Fixes property access in ROI key generation |
| src/components/SlideViewer.tsx | Replaces console calls with logger, updates segmentation handling logic |
| src/components/SegmentItem.tsx | Conditionally shows color controls based on segmentation type |
| public/config/*.js | Adds logger configuration to all config files |
| docs/LOGGER_CONFIGURATION.md | Documentation for the new logger configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@igoroctaviano #330 is still there from what I can tell! |
|
@fedorov have you redeployed and tested 330 again? |
|
Did this just now! Great job @igoroctaviano! You did some updates since I tested - should I redeploy and test again before merging? Or are you still working on this PR? |
Now I wont make any changes so feel free to test then I'll merge and update idc fork too. |
|
Igor, looks good - please proceed with merging! |
|
Uh oh!
There was an error while loading. Please reload this page.