Skip to content

Add postgresql to container build#5

Merged
crivetimihai merged 1 commit intomainfrom
postgresql-dependency
May 27, 2025
Merged

Add postgresql to container build#5
crivetimihai merged 1 commit intomainfrom
postgresql-dependency

Conversation

@crivetimihai
Copy link
Copy Markdown
Member

No description provided.

@crivetimihai crivetimihai merged commit 973ed20 into main May 27, 2025
0 of 3 checks passed
@crivetimihai crivetimihai deleted the postgresql-dependency branch June 2, 2025 06:14
vk-playground pushed a commit to vk-playground/mcp-context-forge that referenced this pull request Sep 14, 2025
Add postgresql to container build

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
vk-playground pushed a commit to vk-playground/mcp-context-forge that referenced this pull request Sep 14, 2025
Add postgresql to container build
vk-playground pushed a commit to vk-playground/mcp-context-forge that referenced this pull request Sep 16, 2025
Add postgresql to container build
Signed-off-by: Vicky Kuo <vicky.kuo@ibm.com>
hughhennelly added a commit to hughhennelly/mcp-context-forge that referenced this pull request Feb 12, 2026
- Fix database import: from ..database to from ..db
- Fix unified_pdp imports: from plugins.unified_pdp (Issue #1)
- Remove scratch header files (Issue IBM#5)

Related to PR feedback on Issue IBM#2226

Signed-off-by: hughhennelly <hughhennelly06@gmail.com>
hughhennelly added a commit to hughhennelly/mcp-context-forge that referenced this pull request Feb 12, 2026
1. Fix broken imports (Issue #1):
   - Change from ..database to ..db
   - Fix unified_pdp imports to use plugins.unified_pdp
   - Update in routes, services, schemas, and tests

2. Register sandbox router in main.py (Issue IBM#2):
   - Add import and app.include_router call

3. Fix XSS vulnerability (Issue IBM#3):
   - Replace f-string HTML with Jinja2 template
   - Create sandbox_simulate_results.html template
   - Add Request parameter for template access

4. Add authentication (Issue IBM#4):
   - Add Depends(get_current_user) to simulate endpoint

5. Remove scratch files (Issue IBM#5):
   - Delete sandbox_header.txt and sandbox_new_header.txt

6. Resolve schemas conflict (Issue IBM#6):
   - Merge schemas/sandbox.py into schemas.py
   - Remove conflicting schemas/ directory
   - Update imports in routes and services

All changes tested and ready for review.

Related to IBM#2226

Signed-off-by: hughhennelly <hughhennelly06@gmail.com>
yiannis2804 added a commit to yiannis2804/mcp-context-forge that referenced this pull request Feb 19, 2026
Address code review feedback from @jonpspri:

Problem: PR description claimed 'Full audit trail of all access decisions'
but _log_decision() only logged to Python logger with TODO comment.

Solution:
- Updated docstring to clarify DB audit logging is Phase 2
- Changed logging level from INFO to DEBUG (reduce production noise)
- AccessDecisionLog table is created and ready for Phase 2
- Honest about current state vs future implementation

Result:
- Clear documentation that DB audit is Phase 2 scaffolding
- Application logging still captures all decisions
- Table structure ready for Phase 2 implementation
- No misleading claims in PR description

Related: PR IBM#2682 Phase 1 Code Review Item IBM#5
Signed-off-by: yiannis2804 <yiannis2804@gmail.com>
crivetimihai pushed a commit that referenced this pull request Feb 24, 2026
Address code review feedback from @jonpspri:

Problem: PR description claimed 'Full audit trail of all access decisions'
but _log_decision() only logged to Python logger with TODO comment.

Solution:
- Updated docstring to clarify DB audit logging is Phase 2
- Changed logging level from INFO to DEBUG (reduce production noise)
- AccessDecisionLog table is created and ready for Phase 2
- Honest about current state vs future implementation

Result:
- Clear documentation that DB audit is Phase 2 scaffolding
- Application logging still captures all decisions
- Table structure ready for Phase 2 implementation
- No misleading claims in PR description

Related: PR #2682 Phase 1 Code Review Item #5
Signed-off-by: yiannis2804 <yiannis2804@gmail.com>
crivetimihai pushed a commit that referenced this pull request Feb 24, 2026
- Fix database import: from ..database to from ..db
- Fix unified_pdp imports: from plugins.unified_pdp (Issue #1)
- Remove scratch header files (Issue #5)

Related to PR feedback on Issue #2226

Signed-off-by: hughhennelly <hughhennelly06@gmail.com>
crivetimihai pushed a commit that referenced this pull request Feb 24, 2026
1. Fix broken imports (Issue #1):
   - Change from ..database to ..db
   - Fix unified_pdp imports to use plugins.unified_pdp
   - Update in routes, services, schemas, and tests

2. Register sandbox router in main.py (Issue #2):
   - Add import and app.include_router call

3. Fix XSS vulnerability (Issue #3):
   - Replace f-string HTML with Jinja2 template
   - Create sandbox_simulate_results.html template
   - Add Request parameter for template access

4. Add authentication (Issue #4):
   - Add Depends(get_current_user) to simulate endpoint

5. Remove scratch files (Issue #5):
   - Delete sandbox_header.txt and sandbox_new_header.txt

6. Resolve schemas conflict (Issue #6):
   - Merge schemas/sandbox.py into schemas.py
   - Remove conflicting schemas/ directory
   - Update imports in routes and services

All changes tested and ready for review.

Related to #2226

Signed-off-by: hughhennelly <hughhennelly06@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant