fix(ui): search-only non-members in Manage Members modal#3209
Closed
crivetimihai wants to merge 3 commits intomainfrom
Closed
fix(ui): search-only non-members in Manage Members modal#3209crivetimihai wants to merge 3 commits intomainfrom
crivetimihai wants to merge 3 commits intomainfrom
Conversation
Closes #3085 Signed-off-by: Oriol Morros Vilaseca <OM368@student.aru.ac.uk>
…minimum in team members modal Signed-off-by: Oriol Morros Vilaseca <OM368@student.aru.ac.uk>
5 tasks
Contributor
|
Hi @crivetimihai thanks for reopening this! I've verified the code, everything looks good, intact and matching my original changes. Ready for review whenever you get the chance. Thanks! |
vishu-bh
approved these changes
Feb 25, 2026
Collaborator
vishu-bh
left a comment
There was a problem hiding this comment.
Great work @omorros tackling scalability issue: moving non-members to explicit, server-side search with a 2-character minimum and capped results is a practical fix that protects the UI from DOM overload while keeping the Manage Members workflow usable.
Looks good to me. Thanks!!
Collaborator
|
@omorros there are conflicts on this PR. Can you resolve them and it can reviewed again. Thanks! |
9 tasks
Contributor
Collaborator
|
Closing this PR, as it is a dupilicate of #3610 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Related Issue
Closes #3085
📝 Summary
The Manage Members modal loaded all non-members eagerly via infinite scroll, which crashed browsers at 20K+ users due to DOM accumulation.
Changes:
🏷️ Type of Change
🧪 Verification
make lintmake testmake coverage✅ Checklist
make black isort pre-commit)📓 Notes (optional)
Files changed (4):