fix: constrain Team Manage Members modal height to viewport (#2930)#2937
Merged
crivetimihai merged 1 commit intoIBM:mainfrom Feb 14, 2026
Merged
Conversation
Signed-off-by: Oriol Morros Vilaseca <OM368@student.aru.ac.uk>
7ff0cd7 to
391ed50
Compare
crivetimihai
approved these changes
Feb 14, 2026
Member
crivetimihai
left a comment
There was a problem hiding this comment.
Clean, well-scoped fix — thanks @omorros!
The two-level scroll containment (90vh on the modal + max-h-64 on inner lists) is the right approach, and the inline style workaround for the airgapped Tailwind build is well documented in the PR description.
Rebased onto main and force-pushed — no conflicts.
suciu-daniel
pushed a commit
that referenced
this pull request
Feb 16, 2026
vishu-bh
pushed a commit
that referenced
this pull request
Feb 18, 2026
kcostell06
pushed a commit
to kcostell06/mcp-context-forge
that referenced
this pull request
Feb 24, 2026
IBM#2937) Signed-off-by: Oriol Morros Vilaseca <OM368@student.aru.ac.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Related Issue Closes #2930
📝 Summary
Fix the Team Manage Members modal height automatically expanding when scrolling through the "Users to Add" section, which
pushed the "Save Changes" button off-screen.
Changes:
90vhwithoverflow-y: autoso it never outgrows the viewportoverflow-hiddenfrom the modal container which was clipping contentmax-h-32tomax-h-64for better usability while keeping them scrollable🏷️ Type of Change
🧪 Verification
make lintmake testmake coverageManual testing:
✅ Checklist
make black isort pre-commit)📓 Notes (optional)
Used inline
style="max-height: 90vh; overflow-y: auto"instead of Tailwind'smax-h-[90vh]because the airgapped Tailwindbuild does not support arbitrary bracket values.