gdcm, itk, vtk@8.2: drops, migrations, and re-deprecation#107657
Closed
cho-m wants to merge 3 commits intoHomebrew:masterfrom
Closed
gdcm, itk, vtk@8.2: drops, migrations, and re-deprecation#107657cho-m wants to merge 3 commits intoHomebrew:masterfrom
cho-m wants to merge 3 commits intoHomebrew:masterfrom
Conversation
cho-m
commented
Aug 9, 2022
Formula/itk.rb
Outdated
Comment on lines
65
to
66
Member
Author
There was a problem hiding this comment.
Enabled general ITK_USE_SYSTEM_LIBRARIES. Also added ITK_USE_SYSTEM_DOUBLECONVERSION, which isn't enabled by general option and needs to be manually set.
Note that there is a bundled copy of openjpeg that cannot be dropped due to InsightSoftwareConsortium/ITK#1807
cho-m
commented
Aug 9, 2022
Formula/itk.rb
Outdated
Comment on lines
46
to
50
Member
Author
There was a problem hiding this comment.
Dropped BUILD_TESTING as it is part of std_cmake_args.
Dropped ITK_USE_STRICT_CONCEPT_CHECKING as no longer used https://github.com/InsightSoftwareConsortium/ITK/blob/v5.2.1/CMakeLists.txt#L485-L487
if(ITK_USE_STRICT_CONCEPT_CHECKING)
message(WARNING "Compilers requiring ITK_USE_STRICT_CONCEPT_CHECKING are no longer suppported. This variable is no longer used.")
endif()Other changes are mainly re-ordering.
This was referenced Aug 9, 2022
This was referenced Aug 10, 2022
Merged
branchv
approved these changes
Aug 16, 2022
Contributor
|
🤖 A scheduled task has triggered a merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?jpeg-turbo,python@3.10, andffmpeg#107250